From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 0) id 34B92394442E; Fri, 20 Mar 2020 16:02:13 +0000 (GMT) Resent-From: Christopher Faylor Resent-Date: Fri, 20 Mar 2020 16:02:13 +0000 Resent-Message-ID: <20200320160213.GB31709@server2.sourceware.org> Resent-To: gdb-patches@sourceware.org Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.39]) by sourceware.org (Postfix) with ESMTPS id 18BA9385F01B for ; Fri, 20 Mar 2020 15:52:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 18BA9385F01B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 9F009D75DF for ; Fri, 20 Mar 2020 10:52:58 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id FJxCjHdzx1s2xFJxCjzt1x; Fri, 20 Mar 2020 10:52:58 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jO2hEZAW0gnYm79HpWcENRC5zvcE2AzLWNWsgcsCqE4=; b=jeQl+o7JblHYlcrEAV08xmO/3+ 2/rMn5MD+L0slqRu9C+DfdRV4Mw+uwlQE5vF+jcE+NQXvBD1owlDoQB6IQ9IdrdDng6Ud3x7/KErX 5IkgvAxEee6MoNTqMDtkWkbg3; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:43062 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jFJxC-000KOY-Dy; Fri, 20 Mar 2020 09:52:58 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/testsuite] Fix gdb.threads/omp-par-scope.exp XPASS References: <20200319100302.GA10681@delia> X-Attribution: Tom Date: Fri, 20 Mar 2020 09:52:57 -0600 In-Reply-To: <20200319100302.GA10681@delia> (Tom de Vries's message of "Thu, 19 Mar 2020 11:03:04 +0100") Message-ID: <87pnd7kopy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2020 16:02:13 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> This is due to the fact that num is missing in the locals, so instead we find Tom> the enum member 'num' of enum expression_operator in glibc/intl/plural-exp.h. lol Tom> Fix this by getting the value using a new proc get_local_valueof, which uses Tom> the "info locals" commands to get the value. Tom> Tested on x86_64-linux, with gcc 7.5.0 (where the test xfails) and gcc Tom> 10.0.1 (where the test passes). Tom> OK for trunk? I think omp-par-scope.exp could use a note explaining why get_local_valueof is needed. Otherwise this looks good to me, please check it in with that change. thanks, Tom