From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 48E02385BF81 for ; Wed, 8 Apr 2020 20:33:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 48E02385BF81 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 22009117FCC; Wed, 8 Apr 2020 16:33:14 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id iZzJlRPW-1zK; Wed, 8 Apr 2020 16:33:14 -0400 (EDT) Received: from murgatroyd (174-16-110-145.hlrn.qwest.net [174.16.110.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id C4CB4117E72; Wed, 8 Apr 2020 16:33:13 -0400 (EDT) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 00/29] Windows code sharing + bug fix References: <20200313190855.28662-1-tromey@adacore.com> X-Attribution: Tom Date: Wed, 08 Apr 2020 14:33:13 -0600 In-Reply-To: <20200313190855.28662-1-tromey@adacore.com> (Tom Tromey's message of "Fri, 13 Mar 2020 13:08:26 -0600") Message-ID: <87pnchogza.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2020 20:33:15 -0000 >>>>> "Tom" == Tom Tromey writes: Tom> This is v3 of the series to share a lot of the Windows code between Tom> gdb and gdbserver. It also fixes a bug that a customer reported; in Tom> fact this fix was the origin of this series. See patch #11 for Tom> details on the bug. Tom> I think this addresses all the review comments. It's somewhat hard to Tom> be sure since they were done in gerrit, and extracting comments from Tom> that is a pain. Also I think I had sent v2 before I updated my Tom> scripts to preserve the gerrit change ID, so it is in gerrit twice. Tom> Anyway, the reviews happened around Nov 2019, so you can find some in Tom> the mailing list archives. Tom> I tested this largely by hand. I also ran it through the AdaCore test Tom> suite, where it did ok. (There were some issues, but I think they are Tom> largely unrelated; some things like gdb printing paths that the test Tom> suite didn't really recognize.) Tom> I've also updated this to handle the WOW64 stuff, but only in a Tom> minimal way -- I didn't try to make this work in gdbserver. I'm checking this in now. Let me know if there are any issues. Tom