From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tromey@adacore.com>
Received: from rock.gnat.com (rock.gnat.com [205.232.38.15])
 by sourceware.org (Postfix) with ESMTP id 2BAA9384C005
 for <gdb-patches@sourceware.org>; Tue, 28 Jul 2020 17:01:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2BAA9384C005
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=adacore.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=tromey@adacore.com
Received: from localhost (localhost.localdomain [127.0.0.1])
 by filtered-rock.gnat.com (Postfix) with ESMTP id 0004A116AFB;
 Tue, 28 Jul 2020 13:01:18 -0400 (EDT)
X-Virus-Scanned: Debian amavisd-new at gnat.com
Received: from rock.gnat.com ([127.0.0.1])
 by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id mfmLOqvifl3k; Tue, 28 Jul 2020 13:01:18 -0400 (EDT)
Received: from murgatroyd (174-16-104-48.hlrn.qwest.net [174.16.104.48])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by rock.gnat.com (Postfix) with ESMTPSA id 97045116AAE;
 Tue, 28 Jul 2020 13:01:18 -0400 (EDT)
From: Tom Tromey <tromey@adacore.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org,  Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Fix bug in DW_OP_GNU_variable_value evaluation
References: <20200727204644.2410247-1-tromey@adacore.com>
 <20200727182320.2aa49b7a@f32-m1.lan>
X-Attribution: Tom
Date: Tue, 28 Jul 2020 11:01:18 -0600
In-Reply-To: <20200727182320.2aa49b7a@f32-m1.lan> (Kevin Buettner's message of
 "Mon, 27 Jul 2020 18:23:20 -0700")
Message-ID: <87pn8f60bl.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2020 17:01:20 -0000

>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:

>> gdb/ChangeLog
>> 2020-07-27  Tom Tromey  <tromey@adacore.com>
>> 
>> * dwarf2/expr.c (dwarf_expr_context::execute_stack_op)
>> <DW_OP_GNU_variable_value>: Cast to address type.
>> 
>> gdb/testsuite/ChangeLog
>> 2020-07-27  Tom Tromey  <tromey@adacore.com>
>> 
>> * gdb.dwarf2/varval.exp (setup_exec): Add 'or' instruction to
>> 'varval' location.

Kevin> LGTM.

Thanks.  I am going to check this one in.

Tom