From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by sourceware.org (Postfix) with ESMTPS id F103E386101D for ; Mon, 3 Aug 2020 16:46:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F103E386101D Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 073Gg1Dg071599; Mon, 3 Aug 2020 16:46:53 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 32nc9ye5us-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 03 Aug 2020 16:46:53 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 073GhfZG071420; Mon, 3 Aug 2020 16:46:52 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 32njav7ajg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 03 Aug 2020 16:46:52 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 073GkppS002718; Mon, 3 Aug 2020 16:46:51 GMT Received: from termi.oracle.com (/10.175.1.95) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 03 Aug 2020 09:46:50 -0700 From: "Jose E. Marchesi" To: Simon Marchi Cc: "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" Subject: Re: [PATCH V6 1/3] gdb: support for eBPF References: <20200803140237.14476-1-jose.marchesi@oracle.com> <20200803140237.14476-2-jose.marchesi@oracle.com> <87o8nrengw.fsf@oracle.com> <3c096b51-21f1-5286-69a1-dd24e3dc1ffe@simark.ca> Date: Mon, 03 Aug 2020 18:46:47 +0200 In-Reply-To: <3c096b51-21f1-5286-69a1-dd24e3dc1ffe@simark.ca> (Simon Marchi's message of "Mon, 3 Aug 2020 12:00:17 -0400") Message-ID: <87pn87d6dk.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9702 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008030122 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9702 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 mlxscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008030122 X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2020 16:46:58 -0000 >> I prefer to write (and maintain) C. >> > > Just pretend that you've done > > typedef struct { > ... > } foo; > > instead of > > struct foo > { > ... > }; > > and there there is > > #define nullptr NULL > > :) Well, I'm not that sure these equivalences are actually homomorphic but that's precisely the point: I would rather not have to figure it out XD > FWIW, I agree with Baris on that, but it's not something worth > fighting over, especially for tdep code. As long as you maintain it, > I think it's ok to have a bit of artistic freedom. For common code, > we probably want to enforce a more consistent style though. Thanks, much appreciated.