From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uAvECdLyCWDoFAAAWB0awg (envelope-from ) for ; Thu, 21 Jan 2021 16:32:02 -0500 Received: by simark.ca (Postfix, from userid 112) id 251601EF80; Thu, 21 Jan 2021 16:32:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CBEC21E590 for ; Thu, 21 Jan 2021 16:32:01 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 936133959E65; Thu, 21 Jan 2021 21:32:01 +0000 (GMT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.149.13]) by sourceware.org (Postfix) with ESMTPS id 8D6E33959E5F for ; Thu, 21 Jan 2021 21:31:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8D6E33959E5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 1A82894CBDA for ; Thu, 21 Jan 2021 15:31:59 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2hYdlR2vvsvw92hYdlfi60; Thu, 21 Jan 2021 15:31:59 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uwiCrWhnatGw7AzwuF4x+VP5K+Z/25ACTbwgicBQrVM=; b=sv9CG9MrHXPxP/UvjKAFeAeD6g UyQZTVuuETqXNhxzaWRMy/t9eKzSiYCoXmrPBnme0+bAvsBEo+F+y5+/3G5S1CiU948YsYB2FHb5C G9GJZpdDaY+NoqbTnC4JX3rVa; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:35788 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l2hYc-0041EN-QB; Thu, 21 Jan 2021 14:31:58 -0700 From: Tom Tromey To: Zoran Zaric via Gdb-patches Subject: Re: [PATCH 06/30] Move get_object_address to dwarf_expr_context References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-7-Zoran.Zaric@amd.com> X-Attribution: Tom Date: Thu, 21 Jan 2021 14:31:57 -0700 In-Reply-To: <20201207190031.13341-7-Zoran.Zaric@amd.com> (Zoran Zaric via Gdb-patches's message of "Mon, 7 Dec 2020 19:00:07 +0000") Message-ID: <87pn1yq8mq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l2hYc-0041EN-QB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:35788 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: Zoran> Following the idea of merging the evaluators, the get_object_address Zoran> and can be moved from dwarf_expr_executor and dwarf_evaluate_loc_desc Zoran> classes to their base class dwarf_expr_context. Zoran> gdb/ChangeLog: Zoran> * dwarf2/expr.c (dwarf_expr_context::get_object_address): Move Zoran> from dwarf_evaluate_loc_desc. Zoran> (class dwarf_expr_context): Add object address member to Zoran> dwarf_expr_context. Zoran> * dwarf2/expr.h (dwarf_expr_context::get_frame_pc): Remove Zoran> method. Zoran> * dwarf2/frame.c (dwarf_expr_executor::get_object_address): Zoran> Remove method. Zoran> * dwarf2/loc.c (dwarf_evaluate_loc_desc::get_object_address): Zoran> move to dwarf_expr_context. Zoran> (class dwarf_evaluate_loc_desc): Move object address member to Zoran> dwarf_expr_context. Thank you. Zoran> + per_cu (nullptr), Zoran> + obj_address (0) Another thing I forgot earlier is that gdb is usually using inline initialization for things like this. Zoran> + /* Object address used for the evaluation. */ Zoran> + CORE_ADDR obj_address; ... so this could just be " = 0". This could be applied in the other patches as well. Otherwise this looks good to me. Tom