Re: [PATCH v4 3/3] dwarf, fortran: add support for DW_TAG_entry_point

[Tom Tromey <tom@tromey.com>]

>>>>> Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org> writes:

> Fortran provides additional entry points for subroutines and functions.
> These entry points may use only a subset (or a different set) of the
> parameters of the original subroutine.  The entry points may be described
> via the DWARF tag DW_TAG_entry_point.

> @@ -21797,12 +21852,15 @@ determine_prefix (struct die_info *die, struct dwarf2_cu *cu)
>  	return "";
>        case DW_TAG_subprogram:
>  	/* Nested subroutines in Fortran get a prefix with the name
> -	   of the parent's subroutine.  */
> +	   of the parent's subroutine.  Entry points are prefixed by the
> +	   parent's namespace.  */
>  	if (cu->lang () == language_fortran)
>  	  {
>  	    if ((die->tag ==  DW_TAG_subprogram)
>  		&& (dwarf2_name (parent, cu) != NULL))
>  	      return dwarf2_name (parent, cu);
> +	    else if (die->tag == DW_TAG_entry_point)
> +	      return determine_prefix (parent, cu);
>  	  }

It seems to me that this will also need a special case in
cooked_indexer::index_dies to ensure that the cooked_index_entry for the
entry point has the correct parent.  Parent relationships are how name
components are determined there, so IIUC the entry point's parent should
be the same as the subroutine's parent -- not the subroutine itself.

One way to see whether this works is to write a .gdb_index and then dump
it and examine the resulting name of the entry point.

thanks,
Tom