From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id i7YXCdwtpGe31iUAWB0awg (envelope-from ) for ; Wed, 05 Feb 2025 22:34:52 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=HJw8GIfn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 16EDF1E105; Wed, 5 Feb 2025 22:34:52 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8545D1E05C for ; Wed, 5 Feb 2025 22:34:51 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 324CD3858429 for ; Thu, 6 Feb 2025 03:34:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 324CD3858429 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=HJw8GIfn Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id B5C40385843B for ; Thu, 6 Feb 2025 03:34:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B5C40385843B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B5C40385843B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738812862; cv=none; b=RS4acKmAaJFdf2zmEz7W/AeSuiHPK45SitsiU5PKqyy4vkVHrsKOGS8olrAN1CplFStwBsX39sSQKs9GRRT/JZBJGdqEt8c2xv5rwo/2801bKYlFeLEiM/hDPSQBIiM0HtLMeegL6fnzhrXF9ms/J80XlJJ4xCMNuhgzEfBjFUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738812862; c=relaxed/simple; bh=EZpiajFM53JWKWSOgTznSWmLRCLDRYzjBO1sPBUeA0s=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HcYEezC38TTsKHZhp8wu2iJeQjGnkGhxtkoJReH/BFZpwgKWKWQ/uftvGS2lwhm/1waEFVQ8I1IlYFqJ8xM3uog/BnCWRDsvRex3uv7HSC6sXwl7s1uO5RzQWE6m+0E2H3aFy6RvURiXqi+wAfhjAIETcp94eE9jEflCyu6x2Ek= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B5C40385843B Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-21661be2c2dso9278475ad.1 for ; Wed, 05 Feb 2025 19:34:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738812862; x=1739417662; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=bKChGOCZ1Ec6vfSvYRxW2aZ8RVX9/6zU0Wq7PnKSV8g=; b=HJw8GIfnYIWDej36m2FMvcbQkloRWiDBLPzDgvIBhbw88rXsTKIKgt7FZtqbGajTzu w1DtY8mLD96bi6DFe0o6ACh5rlkDOI970IGVVcLkB30UeCSUbkhv+y/iz757FdFrmtvY TISeVLY3cc+qvRGqHMbdkas5jIba0CRpW2xkiVn/IYiaQ/DFgak9zUmtOOslXtL1ubuA UhV9swTL+wUUGcBUoUXKKNFlYUucyyiilciLFTkmPeljrwuNgzrvdvijD8+VcLSRzhi0 Gr+ZDoC0/N0ehzPk/3YtY312w0iOMzDrz/76jZVUZvGd9z/rT4lh7ts+lbhEmj5IvIUz fJXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738812862; x=1739417662; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bKChGOCZ1Ec6vfSvYRxW2aZ8RVX9/6zU0Wq7PnKSV8g=; b=wDSP6dSCH+A24aw8lP880nnJHxOGfWqdV5Odfm95m6Cu4eG4FVSbDKPlvctkj9yJWk un5G4Op0oKMXyKJjI6TtC+mIkQhm1ZnXeQQWx9Mh//7+oxNyvtYSbnPZdcV5BsT1ARRB rQkmpRO2lrEIyvMaeh446famiicrWvDsII3tiKknQ/dByy6NvIqvlZfWrvBID3XTUOEL JuCU5C/ubqNKQHx25r9PE1zaweIfeSm0AY0L7mmaLnIrbec3kCRnPGe6Opl2tBPTYwle y1uYQyTD/c0JJ62R4kJ8aybZAyIKJvqim68caZjB7MFi+t0N2+Md/RiXLzZbPxAxqrEQ bbDg== X-Gm-Message-State: AOJu0Ywy/0qdVJ0qoIdW3u31apm13hsHOsSgbTNUKKXTTeRzJdsvmJ0R DP2uZHuVU8w9shQmcpLSXZb4KIY1wAV4o/yWb+8AG7o0y+t+pUpSwGWesHokkUA= X-Gm-Gg: ASbGnctUL6MEFMYzFZaqBmPtlIU4QU1pDxIqJHQldwj55UikFWz4Zg34EgkDiRhgzyS z//bNk4nmeWVJ7szPowC8dYwJvVoGIDAnFgD1TopNPerWflQ0zRfDjLCgo3NYz+oxeIuiEsxbaL xv/KfttL2jtMPPE0bLvS+kv04GyK0aMeX4/qrWMR8ECsiffFQ7EDWJn0w+6FuA+HJxqiYidskRL OxH5OGI6WTD9tTu9OC8EEJ3LIODtIyKJrVOsQr338s1NcOuCZXhKv/RQorwh+yVa9dplvFXftSo b7Cvv1/jdf4IMtxL+mRj4xw= X-Google-Smtp-Source: AGHT+IElCSqxicQlE+EaVbIRJCW4vCtapd2nHKUAJ+ve/nDTGjjlNDcOvaWdGyl/R76ibhBS8rN7MQ== X-Received: by 2002:a17:903:228a:b0:216:7cbf:9500 with SMTP id d9443c01a7336-21f17df5bedmr76597645ad.6.1738812861816; Wed, 05 Feb 2025 19:34:21 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:7e5:16be:a0c6:ff7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f3683e064sm1650665ad.111.2025.02.05.19.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 19:34:21 -0800 (PST) From: Thiago Jung Bauermann To: "Schimpe, Christina" Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 10/12] gdb: Implement amd64 linux shadow stack support for inferior calls. In-Reply-To: <20241220200501.324191-11-christina.schimpe@intel.com> (Christina Schimpe's message of "Fri, 20 Dec 2024 20:04:59 +0000") References: <20241220200501.324191-1-christina.schimpe@intel.com> <20241220200501.324191-11-christina.schimpe@intel.com> User-Agent: mu4e 1.12.8; emacs 29.4 Date: Thu, 06 Feb 2025 00:34:17 -0300 Message-ID: <87pljvhhl2.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org "Schimpe, Christina" writes: > This patch enables inferior calls to support Intel's Control-Flow > Enforcement Technology (CET), which provides the shadow stack feature > for the x86 architecture. > Following the restriction of the linux kernel, enable inferior calls > for amd64 only. > --- > gdb/amd64-linux-tdep.c | 89 +++++++++++++++++-- > gdb/doc/gdb.texinfo | 29 ++++++ > .../gdb.arch/amd64-shadow-stack-cmds.exp | 55 +++++++++++- > 3 files changed, 164 insertions(+), 9 deletions(-) Just a small nit below. Reviewed-by: Thiago Jung Bauermann > diff --git a/gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp b/gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp > index 17f32ce3964..df654f9db5d 100644 > --- a/gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp > +++ b/gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp > @@ -13,12 +13,29 @@ > # You should have received a copy of the GNU General Public License > # along with this program. If not, see . > > -# Test shadow stack enabling for frame level update and the return command. > +# Test shadow stack enabling for frame level update, the return and the > +# call command. "command" should be plural above. -- Thiago