From: Tom Tromey <tom@tromey.com>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3] gdb, configure: Add disable-formats option for configure
Date: Mon, 07 Apr 2025 13:23:56 -0600 [thread overview]
Message-ID: <87plhnydv7.fsf@tromey.com> (raw)
In-Reply-To: <296b9f38-16ef-4488-ba5a-58394bde1fbb@redhat.com> (Guinevere Larsen's message of "Mon, 7 Apr 2025 14:48:45 -0300")
Guinevere> I'm fine with changing this. I'm only unsure what GNU make
Guinevere> feature you mean. I suppose you mean the makefile should
Guinevere> have:
Guinevere> elf_OBJS=elfread.c
Guinevere> xcoff_OBJS=xcoff.c
Guinevere> all_format_OBJS="$(elf_OBJS) $(xcoff_OBJS) ..."
Yeah.
Guinevere> and there is some way to parse --enable-binary-file-formats
Guinevere> in the makefile?
This bit would still have to be in configure. configure would just
select which object keywords end up in some list.
Basically I don't really like that the configure script has to be edited
when shuffling source files around. Decisions about what to include or
exclude can be in configure, but decisions about the files themselves
should just be in makefile.
Tom
next prev parent reply other threads:[~2025-04-07 19:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 11:58 Guinevere Larsen
2025-03-07 12:09 ` Eli Zaretskii
2025-03-07 12:49 ` Guinevere Larsen
2025-03-07 13:03 ` Eli Zaretskii
2025-03-27 20:21 ` [PING][PATCH " Guinevere Larsen
2025-04-03 17:35 ` [PATCH " Tom Tromey
2025-04-07 17:48 ` Guinevere Larsen
2025-04-07 19:23 ` Tom Tromey [this message]
2025-04-08 13:47 ` [PATCH v4] " Guinevere Larsen
2025-04-08 14:06 ` Andreas Schwab
2025-04-08 14:24 ` Guinevere Larsen
2025-04-08 14:44 ` Andreas Schwab
2025-05-26 17:11 ` [PATCH v5 1/1] " Guinevere Larsen
2025-07-07 20:16 ` [PATCH v6] " Guinevere Larsen
2025-07-31 18:42 ` [PING][PATCH " Guinevere Larsen
2025-08-05 16:03 ` [PATCH " Simon Marchi
2025-08-05 19:06 ` Eli Zaretskii
2025-08-05 19:36 ` Simon Marchi
2025-08-05 20:07 ` Guinevere Larsen
2025-08-06 13:53 ` Guinevere Larsen
2025-08-06 14:17 ` [PATCH v7 1/1] gdb, configure: Add enable-binary-file-format " Guinevere Larsen
2025-08-14 15:39 ` Tom Tromey
2025-08-14 16:23 ` Guinevere Larsen
2025-05-27 11:32 ` [PATCH v3] gdb, configure: Add disable-formats " Pedro Alves
2025-05-27 16:26 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plhnydv7.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox