From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OB/GNxDSiGhqRj8AWB0awg (envelope-from ) for ; Tue, 29 Jul 2025 09:52:16 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Bf6hwFaG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DDC781E102; Tue, 29 Jul 2025 09:52:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 703E21E091 for ; Tue, 29 Jul 2025 09:52:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 12598385840E for ; Tue, 29 Jul 2025 13:52:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 12598385840E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Bf6hwFaG Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 09C463858C54 for ; Tue, 29 Jul 2025 13:51:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09C463858C54 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 09C463858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753797075; cv=none; b=MCGdf8a2nA1XD/cECrDFOIA7sRZ8oKSncWvZYLCONZeFhGlYl8g4YWUwOQSxT97G/84KpkidS4cxnrtytIq4sHA+Z6A1wlRbXU7cPTtRwx2pXdTgQBhn8cJJvs7HSVniSIK6tg21OcTrjWiVU8z0i3qy9byNFUnRXMfhkgacpLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753797075; c=relaxed/simple; bh=9aA2iGZJ1JuuqvX9buZ7qt3k40rZ7hZ5S+IVpyGm8Os=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tjeBpPspR5J6LEnDV//lxgAT8KAH9t9rBLoj/UyPGFkHNKjGZLS+oFrLFn/uVZiuaLzmHpAfHal1LvxnNOca6qOXVKUNBIkm0o0Ici2PlqnyMGFzX4HiZyKhT+vd6GF74BrN1kiCXuOQ0aSKlsDymuMFvODWrnT4WHoe+xkcloo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 09C463858C54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753797074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pn8hD1ZgBvKmTaGQSI52wckPnLb8mGhc69m8RRkUEVs=; b=Bf6hwFaG2ueS1w58sT9ruQX/dTfko9DS2nlbvtpkth3k0QWWYpmrNf+DGf/apqo0ZTGG4l GnR8JXDrrbJigZ7C2Ssb7tSOnyy9WwcOkVVO02TJHIyp08P7dipobm8qePPiQ9PtwYrz0v WsTBBcO8AAL5/Xd8xYx8MpVNXNNk/4A= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-DWRQ4_ZRNHSEHCep9XrWhQ-1; Tue, 29 Jul 2025 09:51:13 -0400 X-MC-Unique: DWRQ4_ZRNHSEHCep9XrWhQ-1 X-Mimecast-MFC-AGG-ID: DWRQ4_ZRNHSEHCep9XrWhQ_1753797072 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3b7882c0992so1293628f8f.0 for ; Tue, 29 Jul 2025 06:51:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753797072; x=1754401872; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pn8hD1ZgBvKmTaGQSI52wckPnLb8mGhc69m8RRkUEVs=; b=L5rBiwX9ff/V9wK3zqsmBiBbvTuq6FaGjOoq5f4NqNvqBCUSMfMv/L0RmbEWrJtPqF TMxXC0hawhnOzCwOB1BAuETKYCwHknk1fnv6emmF+N610kuSOzEVvmbwChShqtnsNw4t orH7YmSJI5dkd4TsSZoCI9BwGQZxzUJe4Vr8c8BH/lOQOeJbg4C6tNd1+c0/oTtFfXO4 2T4xEhhxKpkI8yg01vXFyyKZHZRE/KslcaxYNHPHaGI21wi+XCOCsD/rDxNkpXMZfy8v xiubuRXDAduyab6b3vfx8jAHY6aFMAtG5lFrdAV0Wiomic7bX1Cfvfrq4E+7WT8GVbiT awDw== X-Forwarded-Encrypted: i=1; AJvYcCVERqbUIRZELhGBgCR8RMx2CPqMNaN4bvq1V7virDXgzSZTEqEzjspWR7TUvnPR1LIrro0LgFW5rLRZ1A==@sourceware.org X-Gm-Message-State: AOJu0YwVzsdcp0mS/HvoaIjEcl/TV1IVa80/+nBzlfoLcBB4zqOnAhP0 rfgnkqLbkEXVGhIP6EW7TgQdUq5zaC7QKhfHHHO8uOxIjIIm4pXaUEoSPRmcAF6prn/3maTD3hz 0hVyeoX6BK89ZvbjbNOsBJbWaPQdB7lxsp48PVS9ws9RTz9NSZ10+tVoeabGy5m8= X-Gm-Gg: ASbGncuiX/tww11MCjOypvxIIkkzHER//tFskL7BJ/G+1Ud6WLThr5WNTWznCVgZjm2 dfk+4OaVATpem0Pw9XgjtMpk3JZq36P6NmIxluSkkIsoxFZKVuQ8M0ztNzBKBkluA1bu1ICs4le KAY0vjBof7eB8Babu5uUueJFAwU0HijFNgKmh1Pctr3VlNeDmJQ3aczXQ2ck57LrgAOKOlWJ+mm Qkb3iuNUzkFxs+S8jEC0qdud37YidUNsec0uIgxYBqz8Hg1P0GB6I6FTYc3PL8wf6e3uKQlE19b ygQ14RHm3Mesdt0pUBrTa4Mrmb6msoL0x6shWWO5RDYR8wbmyxXSzbUdFFV4zw== X-Received: by 2002:a5d:5d11:0:b0:3b7:885e:cd0f with SMTP id ffacd0b85a97d-3b7885ecf83mr5046547f8f.31.1753797071319; Tue, 29 Jul 2025 06:51:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNkvI7aLvd1nXwvhNnVHcYcXUVX0jepBAO1jIlH/qzvaPwYsHZIaS3LCHdcqkIOLFRS+aGKA== X-Received: by 2002:a5d:5d11:0:b0:3b7:885e:cd0f with SMTP id ffacd0b85a97d-3b7885ecf83mr5046523f8f.31.1753797070817; Tue, 29 Jul 2025 06:51:10 -0700 (PDT) Received: from localhost (120.81.93.209.dyn.plus.net. [209.93.81.120]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4588dd2edaasm21784005e9.1.2025.07.29.06.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jul 2025 06:51:10 -0700 (PDT) From: Andrew Burgess To: Christina Schimpe , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org, luis.machado@arm.com Subject: Re: [PATCH v5 06/12] gdb, gdbserver: Add support of Intel shadow stack pointer register. In-Reply-To: <20250628082810.332526-7-christina.schimpe@intel.com> References: <20250628082810.332526-1-christina.schimpe@intel.com> <20250628082810.332526-7-christina.schimpe@intel.com> Date: Tue, 29 Jul 2025 14:51:09 +0100 Message-ID: <87pldjcdgy.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: STjKE6jA8UnpbSOYvy2IzgUoIL9PJbjJb4EpXsK2zHM_1753797072 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Christina Schimpe writes: > diff --git a/gdb/x86-tdep.c b/gdb/x86-tdep.c > index 6646b1157c8..06dec4e1f90 100644 > --- a/gdb/x86-tdep.c > +++ b/gdb/x86-tdep.c > @@ -17,10 +17,31 @@ > You should have received a copy of the GNU General Public License > along with this program. If not, see . */ > > +#include "i386-tdep.h" > #include "x86-tdep.h" > #include "symtab.h" > > > +/* See x86-tdep.h. */ > + > +void > +x86_supply_ssp (regcache *regcache, const uint64_t ssp) > +{ > + i386_gdbarch_tdep *tdep = gdbarch_tdep (regcache->arch ()); > + gdb_assert (tdep != nullptr && tdep->ssp_regnum > 0); > + regcache->raw_supply (tdep->ssp_regnum, &ssp); > +} > + > +/* See x86-tdep.h. */ > + > +void > +x86_collect_ssp (const regcache *regcache, uint64_t& ssp) While reviewing the next patch, I spotted a white space issue here, it should be 'uint64_t &ssp'. And the same in the declaration too. Thanks, Andrew