From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KQmTBAQtYGk7UDMAWB0awg (envelope-from ) for ; Thu, 08 Jan 2026 17:17:40 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=I5NYJWSb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0E9881E08D; Thu, 08 Jan 2026 17:17:40 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 81CA71E08D for ; Thu, 08 Jan 2026 17:17:39 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 0B86A4BA2E21 for ; Thu, 8 Jan 2026 22:17:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B86A4BA2E21 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=I5NYJWSb Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id C69364BA2E05 for ; Thu, 8 Jan 2026 22:17:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C69364BA2E05 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C69364BA2E05 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767910632; cv=none; b=ZolQqdQ32Mb4Ce52vi6vaEwgRV1Bh1oymUN4OWWdcuCBqyc2bB8433MZ3UWneLInU65BHaCiirKREoEwwBQPK9SdWmEPi9PAAUHwg73JfxSTrBtsn6p1chRvbxViJt6JJc+sdNlpv1QUu54t4oM6CasxuG6cCH/QV0GGAJgaZtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767910632; c=relaxed/simple; bh=KtNyVF/Iez0z8OxordX8dLgNE+fqqAKO2RL00FYtgVo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cEjpkyN7tsD4Pe9fqQcON2vSYGDWQX7k5nWJXe7gZCp99JBLD5UqGETZFwgFBTxP3cX4tE9fgcegRG2nsT5urZXyPR2G4xYwqIxd1Hxsc8ZSuQ4sp9sZ+jzOyDnXz4FLISjwpN95KSwK9aCHV9+/eBjDjrJXoYf1spI8Ln1P3b4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id dsHXvzkmBKXDJdyJcvNZwP; Thu, 08 Jan 2026 22:17:12 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id dyJbvzin5PL32dyJbvQou1; Thu, 08 Jan 2026 22:17:12 +0000 X-Authority-Analysis: v=2.4 cv=MqhS63ae c=1 sm=1 tr=0 ts=69602ce8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=tdM4JgHVCmCp5jp3icAA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dFjlmcm/aKZvepwBi0arwGtEzPvHmGvBRt0M8VgzI8A=; b=I5NYJWSbXpxDm1y2Ny/WgoArZq v0PCmdxY/J31CYdKO90Mhu/T1oggqDTDROunyUpimZq7FOdXZFtfqutPsFqUtd0aYPlRsivvArzok 0QvRVEyUFg/pgKIMEF95VPYA7; Received: from 75-166-246-134.hlrn.qwest.net ([75.166.246.134]:59724 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vdyJb-000000016d7-1qfM; Thu, 08 Jan 2026 15:17:11 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 4/8] gdb/xcoffread: remove xcoff_symfile_info::{symtbl, symtbl_num_syms} In-Reply-To: <4a8db879-e6cb-49d7-a084-ad73da2d1654@simark.ca> (Simon Marchi's message of "Thu, 8 Jan 2026 16:24:36 -0500") References: <20260108193507.553779-1-simon.marchi@efficios.com> <20260108193507.553779-5-simon.marchi@efficios.com> <87h5svon90.fsf@tromey.com> <4a8db879-e6cb-49d7-a084-ad73da2d1654@simark.ca> X-Attribution: Tom Date: Thu, 08 Jan 2026 15:17:09 -0700 Message-ID: <87pl7j4umy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.246.134 X-Source-L: No X-Exim-ID: 1vdyJb-000000016d7-1qfM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-246-134.hlrn.qwest.net (prentzel) [75.166.246.134]:59724 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBhmchkh/h8i8QVI6NrKRXwa2D7rNLu1AZqd/sNWWVaenjyYME/bR6/XyZO386s/MTaQ2q3y2yVpQYatCNngHheBcnDxC1gUkEJw97ForFz/rKkQjj8c NUaW7pHHV+Z3wwChhgFZdBhrIM8Rr0ThkJGf7CJ3eFOBOyrEm8JDjDZLkG8seQS/fHHLGgo59udVE9696DBQ2PbxKT2rLL2TMe4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> + /* Seek to symbol table location. */ Simon> + if (int ret = bfd_seek (abfd, symtab_offset, SEEK_SET); Simon> + ret < 0) >> 'ret' doesn't really seem to be needed here. Simon> What do you mean, not needed? Don't we want to check the return value Simon> of bfd_seek? I just mean the variable, so: if (bfd_seek (...) < 0) Tom