From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id nigRIZpLl2lEqwEAWB0awg (envelope-from ) for ; Thu, 19 Feb 2026 12:42:50 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=XWjDr4Ha; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6D3271E089; Thu, 19 Feb 2026 12:42:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B6BA71E089 for ; Thu, 19 Feb 2026 12:42:49 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3D0BE4B9DB5D for ; Thu, 19 Feb 2026 17:42:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D0BE4B9DB5D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=XWjDr4Ha Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id CA5C54BA23CE for ; Thu, 19 Feb 2026 17:42:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA5C54BA23CE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA5C54BA23CE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771522942; cv=none; b=RWrJ2o3/TvNIg888tNK5Mg/WQ45D1YPO+hm94Cd1hP/HC/PEwTkdL35EfslE2smBwbcai4IYnWPfDQAMyns0IzwU1xFFnqT+gEXy3q791rvEpp9pk7A8Oga51Ltib9ULliojUQ9PTZK4ZRpJxI+Bg86DaNw4grXyKwMX58OQtiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771522942; c=relaxed/simple; bh=QXH6bpJE8FyKSWpTYxSbU8sqSXd4C+/hRBj2sxc3rmI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pWBSitjXvZFwTzZMNXOt2wyUuBOGqLUkGSH7ojq1L11fdfDEz5e5pm1SxFgaKwsXGmH3Aj3U6GZWNZYG5AJk26Uq7UwIaZT2XCSgTELGrHG4YatLCsKytC2Bjoj5Dp51aNU/i120Kaoaw1G3I+n1WFuNnNowtNJBpQ2rskkfl1w= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA5C54BA23CE Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id stKmvr6k8ipkCt82evzT5N; Thu, 19 Feb 2026 17:42:20 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id t82Cv29DcqfpWt82CvRFde; Thu, 19 Feb 2026 17:41:53 +0000 X-Authority-Analysis: v=2.4 cv=A55sP7WG c=1 sm=1 tr=0 ts=69974b7c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=zstS-IiYAAAA:8 a=1QnBBVln1j2b6yB9BmYA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CCk5Xrr7s4h2+K4vn02h+fcCmFAVr0ZM2IdLl/YfZtg=; b=XWjDr4HaNU76ebSDkWeN0IEzXY Hb08DOEJOcfJ+oP1z/PO0VeizYfaaWyPhK8knYwGo4OHcIuTUFj9hEbHhB5hkdnFIRXWm4wIzt++Q SxVshlvd7nsR5imMhIE2sswKG; Received: from 97-122-122-234.hlrn.qwest.net ([97.122.122.234]:52488 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vt82C-00000001iuw-1D4Z; Thu, 19 Feb 2026 10:41:52 -0700 From: Tom Tromey To: Christina Schimpe Cc: gdb-patches@sourceware.org, thiago.bauermann@linaro.org Subject: Re: [PATCH v2 7/9] gdb: Provide gdbarch hook to distinguish shadow stack backtrace elements. In-Reply-To: <20260123080532.878738-8-christina.schimpe@intel.com> (Christina Schimpe's message of "Fri, 23 Jan 2026 08:05:29 +0000") References: <20260123080532.878738-1-christina.schimpe@intel.com> <20260123080532.878738-8-christina.schimpe@intel.com> X-Attribution: Tom Date: Thu, 19 Feb 2026 10:41:51 -0700 Message-ID: <87pl60636o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.234 X-Source-L: No X-Exim-ID: 1vt82C-00000001iuw-1D4Z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-234.hlrn.qwest.net (bapiya) [97.122.122.234]:52488 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfISLnqQcP9WpfX1jjRiZOWy6qzHOqkhEttHWq6XdCEp0hXmBs+/k98TNXNshiIdeT6dbDjDpqea9aW4FCXB6RIm5IeTyvQaSchPmuS8oWNVI1bRziSH2 aqMULUPCbxm2ay0lTSN4plIy8EdQWP2RmBNSGQUKd14e6F4zBNqkdfI3+Qy/ytpYVOUVJj5mZKGsO5aRDRxuuy42a2d5s6gFwFw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Christina Schimpe writes: > On x86 with CET or on ARM with GCS, there can be elements on the shadow > stack which are not return addresses. In this case, we don't want to print > the shadow stack element, but a string instead which describes the frame > similar to the normal backtrace command for dummy frames or signals. > Provide a gdbarch hook to distinguish between return and non-return > addresses and to configure a string which is printed instead of the > shadow stack element. This seems reasonable enough to me. Could you double-check that everything is consistent by re-running check-gdbarch.py on your tree? If that is silent then it's fine. > +Return true, if FRAME does not contain a return address in FRAME->VALUE > +but another valid value for the architecture's shadow stack. In this case, > +also the string frame_type has to be configured to display the type in the > +shadow stack backtrace. I wonder if you considered returning a std::optional here instead, just to be sure that the return value and the required auxiliary data could not possibly be out of sync. Anyway, Approved-By: Tom Tromey Tom