From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3Tm4EBCLjGqZKz0AWB0awg (envelope-from ) for ; Mon, 24 Aug 2026 14:18:56 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JS7fUZlu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1C94D1E0A3; Mon, 24 Aug 2026 14:18:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CFC261E033 for ; Mon, 24 Aug 2026 14:18:54 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6993E4BB24E4 for ; Mon, 24 Aug 2026 18:18:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6993E4BB24E4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JS7fUZlu Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 7D1984BB24DD for ; Mon, 24 Aug 2026 18:18:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D1984BB24DD Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D1984BB24DD Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787595490; cv=none; b=Tt6adOxUAmmgDYONyPlRfoHhYATe3agmKVk69Pv78q3ZI7vzsNa8l7lNKtpjIzPWEH4ui01QX7F837/YtBGBOh00fUXnxBRLfAnoTeh0zV75+TlzfPlqPefgN0qIbjxdtZ0kbUlNn3EU7VrURexKmDeudCTo+gpHl3BmyNdzY7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787595490; c=relaxed/simple; bh=73mJtco9rkdSGyG3AsiV6Jl4HW2CIO25pb3iOHkoc74=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Fk2zfTGffqp4q8FuGdCIyGTcOuxx4gWJe/TlvVAyzPairV2B9BNnU7CPBFAOfsyccndbZMUtxJMQeT0WtxRB2hAao/KkYjUVL1EnN2Gn9zzwRr2z0+lGA1EY/gVfBk+5AygY9Iv1IIGgBxKLNF4nVSm5qvCGjD42CoJsTkDKCbM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JS7fUZlu DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D1984BB24DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787595490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QNjdydqrLIMMMdhv5gM0XXwxecpHEhh7EjAl8P3oPqg=; b=JS7fUZluws7qU+AzltOFJ5MclCGaJuSJUAaMy88sT+/GQdy5kj/4ghjWh/iH/9VXyFbNTv kRPaivyEeCBY0r0NJwVvp49k8vq/AmgBwc/oOZrrorQLMPL0oYRylgDFlL5n8gqzy/Uub3 rsoJ5l7rZFj3ssKwUSZYIWsxw03kIVs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-VYzrtwS0Npa2wvG_NJYQfA-1; Mon, 24 Aug 2026 14:18:07 -0400 X-MC-Unique: VYzrtwS0Npa2wvG_NJYQfA-1 X-Mimecast-MFC-AGG-ID: VYzrtwS0Npa2wvG_NJYQfA_1787595486 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-47fe85684b9so3164103f8f.3 for ; Mon, 24 Aug 2026 11:18:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787595486; x=1788200286; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QNjdydqrLIMMMdhv5gM0XXwxecpHEhh7EjAl8P3oPqg=; b=P14yE7WKYyrcQD4gkcyQ4h+VrEM4qicYH+PWISBgnd5UWier8+NESJHdd56ObJIQVg RCNmODt2XKz+rnHvtby128pPXqLjuIPebvg91lx7YdamTIG1Tux0P+/oyOPzRrl47tKj yQNwNrx624BWYKx1EUQ6XO5m1q0wJsC1it0wAWg0BE8lK0LodrrgyKgaUW6JTtnoOErb Epn8JMuk5N/GKzytAXos2T6AMjze0JXgRxU54d/gUMSegRglo3eKAZ0PTYFxUiBb0Wxg PqmWt0hQk0QR1JbXpndm8xfHDBJ7t2fYhrgnE5F9MzRQ/yD1vTc8nWFFTfYHDaMKd2R4 SOuw== X-Forwarded-Encrypted: i=1; AHgh+RoFQX1qiB0+3QGF37yPyugwLeR6w8heqPmgR1fybhVBf+az0fxsMVYWs7VGKnlzdWy6EAw5Rgn1bpcERw==@sourceware.org X-Gm-Message-State: AFuF++kZKQHobaqU4/IhF+sj6FQ8gBa2uIvDK5a0fKEUIC3LKFLwm6aF MvNSCZXe+SQlphy/G7oSVfRRUBylt4TeZftKt2szwiwv1P/k8fXeLe4l6zMUYBtQZQGDmVbN+Lh 0j7sv2NPHuIb1o6gjGedNyPcYjY1mKMc7fVZCmjkv+V6sR3k9jXIYWCTLVN/nNeE= X-Gm-Gg: AR+sD13twzL6DuQOl12Ow4uwg+ARGzmr0RPc4+DHSKDUg2oR8IBFp+dDmaLmg8AM8H1 6gtV5VErk7Q5nlKGYoYy/u34eEPQnMa8ptMPm0G5DxwZdGs3GGcwcWXAxHB0jFmA//DqKXkXs3k uDfY5pVbRVqrRnQC9iht3lOxadF0YjvFSbw1Ae0D+/h/GdmWnufaLVcn+zhexT6EsfMZ5jgd1R7 yU+MK5UbEd4GECBAYOM4Esjv+ln5yF4WoR5wmDjxIOYB5G/9HeNSkVPdAyF1ZlJ2f1vSQzCWft9 8CNad5+tUYuUO/OR25LwsbNwZNI5dI8EsOWrVDD5S53zeNmQKKO0+6jV0sWiYfWDbniW/8foNHs wF5F2dnsLhp3yEITJAnJmMD6e1As= X-Received: by 2002:a05:6000:230a:b0:482:aa2a:52f7 with SMTP id ffacd0b85a97d-482c817acd3mr22052730f8f.6.1787595486085; Mon, 24 Aug 2026 11:18:06 -0700 (PDT) X-Received: by 2002:a05:6000:230a:b0:482:aa2a:52f7 with SMTP id ffacd0b85a97d-482c817acd3mr22052623f8f.6.1787595485548; Mon, 24 Aug 2026 11:18:05 -0700 (PDT) Received: from localhost (128.223.159.143.dyn.plus.net. [143.159.223.128]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482c9b69b7fsm9138847f8f.2.2026.08.24.11.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 11:18:05 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: share some thread proceed related code between CLI and MI In-Reply-To: <75c88f8e-babb-4162-a941-424cb3bb1663@suse.de> References: <55e17e264f17f47680100684c9aa7bd9b88e377c.1786049312.git.aburgess@redhat.com> <87ik5mkkw5.fsf@redhat.com> <75c88f8e-babb-4162-a941-424cb3bb1663@suse.de> Date: Mon, 24 Aug 2026 19:18:04 +0100 Message-ID: <87pkz7tmar.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Q10wgwyCGlbLRYPoi8lFTxNI7MlzInfy2sLnwsTn9Sw_1787595486 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom de Vries writes: > On 8/7/26 5:31 PM, Andrew Burgess wrote: >> Tom de Vries writes: >> >>> On 8/6/26 10:54 PM, Andrew Burgess wrote: >>>> + if (inf == nullptr) >>>> + proceed_all_threads (); >>>> + else >>>> + { >>>> + for (thread_info &thread : inf->threads ()) >>>> + proceed_one_thread (thread); >>>> } >>> >>> FWIW, also I wonder if it makes sense to fold this logic into >>> proceed_all_threads: >> >> I took a look through all the other proceed() calls and couldn't see >> anything else that might want to share this code, so my preference would >> be to leave things as I initially proposed. I like the simpler each >> function has one clear goal, rather than overloading proceed_all_threads >> with multiple meanings ("all threads", or "all threads in inferior"). >> Especially not a fan of default arguments for cases like this (or in >> general much). >> >> That said, if you consider this a blocker to merging this patch then I >> don't feel that strongly against it so would make the change to get this >> fix merged. >> > > Hi Andrew, > > I don't consider this a blocker. Great. I've now pushed these patches. Thanks, Andrew