From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, Tom de Vries <tdevries@suse.de>,
Abhay Kandpal <abhay@linux.ibm.com>
Subject: Re: [PATCH 1/2] gdb: fill in default return types for some inferior function calls
Date: Fri, 11 Sep 2026 08:38:38 -0600 [thread overview]
Message-ID: <87pkyjzwcx.fsf@tromey.com> (raw)
In-Reply-To: <3b7851c296c932da6ddc366810ea6ee9f2f3db6a.1789034019.git.aburgess@redhat.com> (Andrew Burgess's message of "Thu, 10 Sep 2026 14:13:52 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> Given that the return type for munmap is well defined, I think the fix
Andrew> here is to update the call_function_by_hand call to pass in the known
Andrew> default return type. With this done the gdb.compile/ tests now start
Andrew> passing again.
Makes sense to me.
Perhaps this kind of internal call should only use minsyms, with gdb
supplying the function type.
Tom
next prev parent reply other threads:[~2026-09-11 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 13:13 [PATCH 0/2] Fix regressions after find_function_in_inferior changes Andrew Burgess
2026-09-10 13:13 ` [PATCH 1/2] gdb: fill in default return types for some inferior function calls Andrew Burgess
2026-09-11 14:38 ` Tom Tromey [this message]
2026-09-10 13:13 ` [PATCH 2/2] gdb: catch some exceptions in find_function_in_inferior Andrew Burgess
2026-09-11 11:07 ` Tom de Vries
2026-09-11 14:42 ` Tom Tromey
2026-09-11 14:43 ` [PATCH 0/2] Fix regressions after find_function_in_inferior changes Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pkyjzwcx.fsf@tromey.com \
--to=tom@tromey.com \
--cc=abhay@linux.ibm.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox