From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id r+KrH2LZuGrh7AsAWB0awg (envelope-from ) for ; Sun, 27 Sep 2026 04:52:50 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ifsc0eLw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5254C1E06B; Sun, 27 Sep 2026 04:52:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0DDF01E033 for ; Sun, 27 Sep 2026 04:52:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C4D54BA902A for ; Sun, 27 Sep 2026 08:52:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C4D54BA902A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ifsc0eLw Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 9A7444BA79B7 for ; Sun, 27 Sep 2026 08:52:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A7444BA79B7 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A7444BA79B7 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790499141; cv=none; b=gLcyviaTWbshmior6xhd9zI2A/pWTbxpHUPVsatcqlw+ovxEeiY8M6Ps2oB0nwcoaoCbUxf4T4RbY798HtyS3Kp0Fs0q4vRkiUnmpEBPEARjGte8dNGc9vd8dfsF7z31q/cpuMQ08oYIKw1rnvfB5T7XNGYtYe0gPnCJZlHFlO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790499141; c=relaxed/simple; bh=8ZMLx2BH4Ih7ptQC9KbMof0t6kguDdWTrWzGjxIk9gU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ahraQ7QwF/86mqq/Ahqk+gBHUTdBxayRL7eBWawvKKS1Tuva+604BlGRdiDEhdCWKLmqaB1dd+UEaxT5p3Mk+dpZTyejoYeuYv6oxfLbtbG4Pf/ESTX9UPxR4l8GP1RK0YZ9+9+2iw5JwAItCd/LjpOuC1WDhwd1FV6xP2jnLNM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ifsc0eLw DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A7444BA79B7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790499141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2bZMD25vGvifkJNnv0CjdTmvZZBdzoNbqJX8l3BFZT0=; b=ifsc0eLwthVD7X6XC5ZXMolEuaZuC+lFwn1SaqMjQDbFvRnKRon4kYF7l5Ydds9Tc1rPzZ QI2GcWmvBt3gCAtVNlJcCaF98HQAq43sFSrdC0nFfGracZUmwMrFsMXy36wkWb2WZlHgiL 2dB4ZBGTd21Gr6bWFVqOHd1NP5cE2PA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-Dvax7tfqMuKWXWjcYzM0Rw-1; Sun, 27 Sep 2026 04:52:19 -0400 X-MC-Unique: Dvax7tfqMuKWXWjcYzM0Rw-1 X-Mimecast-MFC-AGG-ID: Dvax7tfqMuKWXWjcYzM0Rw_1790499138 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48880800a34so787517f8f.1 for ; Sun, 27 Sep 2026 01:52:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790499138; x=1791103938; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2bZMD25vGvifkJNnv0CjdTmvZZBdzoNbqJX8l3BFZT0=; b=A2UEVjsounxEKIP3YJlFcZAz2I0iIJOW4KsHW6a1gjdw6lcB8/7S8WEk+6jXIA2i1V 46fJ2wxnuLZOtExPLLex+5j83/JS3SPs6r/MyO7l8slT9zNgtaO3d5px3IFQSPeE8wNs D4mbNHKjf0Zs9Ojz6DggfIVd4IFY4ES/tYv6SCPevFiZwV4eUOFhYzJ9mX90gQFx9han kEs3BOVwrPW/JEsMHUE/ffSo9Qc8WXCTq5RR0G6ud/Ak4UuZvruzLS8e0UC/oylS0WkJ 499FePADdBfmfd16ePCi6lBF97aMveJCXjLEeb7DhmocnF1ZZxKw4ZJFj5RSs4Og/XxC jiJw== X-Forwarded-Encrypted: i=1; AKwUvByI6YFSqnW8H8Y9ityAce4J+Vqov7ni9Tq92cScTMFJymUHVoq0pc6M+wPR1bI2riRMMR1IFx/UGvDZYA==@sourceware.org X-Gm-Message-State: AFq9FYKGz0wqJbMXAdRMJOFWm/SnB0PJRtiIrTSeIW9i1j2LDoti9THD eNip4hZ1inLyrU+KBlQsLkzgwHgQVrIEKq/QeAVxY28sMEQABbk7pSqqsU6AXxl7WPNxGUVf7CE 3kem53V80IFEZW+JNfiSbzHTwHZNTo2oboO3fqw9RnwjOhOYvAfLm04cqEYV+a/w= X-Gm-Gg: AYBFou236Mcb962qf8qdMXc06icDC27oV9ubrEnMZxGIcu4WlEVsaBrSR10DRYJ4HCN FJps68xJg4eGUFQeW2hguIvBX5zEx/7uHuVVovaYlm3MbeXX8ce/bqH2DRHtFGy6dfI1qHC16LK WMXoISbuTDFZwx8akTXVaSjGY48cNT92w3v5E+hyY/zuk+gqwAdVEgImZJfFktLPwDqM519EW01 7UOx2y4UNBcfyMiDS57Mo/fh4bfAqLLO5t3BdR3ofpr+1Aeix8XK/C7GkN4S4p3UVUnmyBDoZdV PADcDN2PxEocRvz3IbYt1ITBwTlWDr75KM7OhYGTqM9WQb6mvoz1622s1/v/ZJ/7vbi4 X-Received: by 2002:a05:6000:2886:b0:488:894d:20b0 with SMTP id ffacd0b85a97d-488894d2230mr4971847f8f.44.1790499138246; Sun, 27 Sep 2026 01:52:18 -0700 (PDT) X-Received: by 2002:a05:6000:2886:b0:488:894d:20b0 with SMTP id ffacd0b85a97d-488894d2230mr4971815f8f.44.1790499137740; Sun, 27 Sep 2026 01:52:17 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4887a355d96sm20560249f8f.17.2026.09.27.01.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2026 01:52:16 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] [gdb/testsuite] Use gdb_exit_cleanup a bit more In-Reply-To: <20260919084237.1045724-3-tdevries@suse.de> References: <20260919084237.1045724-1-tdevries@suse.de> <20260919084237.1045724-3-tdevries@suse.de> Date: Sun, 27 Sep 2026 09:52:16 +0100 Message-ID: <87pkxz13gf.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Cn_NvfDW0RRxGJ2IdPVbzHSBdns6qfxJ3RZGqbw_iJg_1790499138 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom de Vries writes: > I ran into trouble running test-case gdb.base/quit-live.exp using a remote > host configuration: > - host board local-remote-host > - target board remote-gdbserver-on-localhost. > > The problem is that the test-case makes gdb quit without updating > gdb_spawn_id. Consequently, default_gdb_exit tries to exit gdb. > It does so by sending quit to gdb and waiting for it to exit, which get us: > ... > ERROR: : spawn id exp9 not open > ... > > Fix this using gdb_exit_cleanup. Likewise in gdb.threads/killed.exp. > --- > gdb/testsuite/gdb.base/quit-live.exp | 1 + > gdb/testsuite/gdb.threads/killed.exp | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/quit-live.exp b/gdb/testsuite/gdb.base/quit-live.exp > index 14f87f9b7f8..8dae4fe2aca 100644 > --- a/gdb/testsuite/gdb.base/quit-live.exp > +++ b/gdb/testsuite/gdb.base/quit-live.exp > @@ -152,6 +152,7 @@ proc quit_with_live_inferior {appear_how extra_inferior quit_how} { > gdb_test_multiple "" $test { > eof { > pass $test > + gdb_exit_cleanup There's another place in this test script which detects eof from GDB, but you've not added the gdb_exit_cleanup call there. Should we also be patching that location? If not why not? And if the answer is there's a good reason why not, then I think it is worth mentioning in the commit message, and as a comment at that location in the code. Thanks, Andrew