Re: [PATCH v2] gdb: Check DW_OP_deref_type size against type

[Tom Tromey <tom@tromey.com>]

>>>>> Jielun Wu <firmiana402@gmail.com> writes:

> DWARF v5 requires the explicit size operand of DW_OP_deref_type to
> match the size of the referenced base type.  The evaluator currently
> passes both sizes to dwarf_expr_context::deref without validating the
> encoding, and the generic dereference helper accepts the mismatch by
> zero-extending the bytes read from memory.

> Reject a mismatch after resolving the base type.  Name the actual opcode
> and report both sizes in the diagnostic.

> Teach the testsuite's DWARF assembler to emit DW_OP_deref_type and
> DW_OP_GNU_deref_type operands.  Add tests covering matching and
> mismatched sizes for both opcodes.

> Tested on x86_64-linux.

Thank you for the patch.  This looks good to me.

If you want to get write-after-access to land this and future patches,
please email me and I will get you set up.

Otherwise let me know and I can check it in.

Approved-By: Tom Tromey <tom@tromey.com>

Tom