From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yUYaCVMv4mpxpj4AWB0awg (envelope-from ) for ; Wed, 28 Oct 2026 13:22:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jap73Y9D; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1D75B378002; Wed, 28 Oct 2026 13:22:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 86E9A1E007 for ; Wed, 28 Oct 2026 13:22:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 18B564BA23CC for ; Wed, 28 Oct 2026 17:22:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 18B564BA23CC Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jap73Y9D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id C38214BA23D5 for ; Wed, 28 Oct 2026 17:21:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C38214BA23D5 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C38214BA23D5 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793208097; cv=none; b=DP1qNKQyfnE/+3397Q1ObU2hCoiLujgYfJ+ay9iairmbAJnhtUIweYKpxLG+MUMsycxZy6PWrqXOIqv81LHbTDUr+RKL1ElnwXujpBcD2qomUgHG4quWHxaiLIKCB2VumkJYbyXwWE1oGGZ0xTKFX6rwd1VZPDGU5j31naOq+HI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793208097; c=relaxed/simple; bh=VbPDlM02s0w83N8bNaUyyqzktLb9Cc/Q6GPWNWwAsHI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=jI71IBK4/3+BzkZp+FizP6bom+XOW0a3QVKz8wgP+2IOqA17o1WGMsIBqbk2IkOlxQ/l/v0rMWvYTY19OpvxT0PqpBqwhQL7Z7W2dF5oPzFsJS7PJTI/BFyUPe93Q0AuR0esbGArhXi5Aaj0MEbL2vocofcexab+gPyp8TIMxyw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jap73Y9D DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C38214BA23D5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793208097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Lro1g9xiJxa67LXGW6AeolwopSOZQh+TCDnEgVoW6CU=; b=Jap73Y9DaQDHdaFMqskDlTjdUT0QqGkgaI38SGBiIoJEFFzFC+CZYk/GRHPCYfJ9tZsWJL HLUdVMeKhEW0fZ1UCKlODrf1nMN7nkB3S154DTm/9QIitl34xgFsOd2SOSxq95HJhfVK+B +xuMslQyKS0ojxG7+Gz/fMMHOmJYYC0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-VRbcK18APUumKptAJG7fsw-1; Wed, 28 Oct 2026 13:21:36 -0400 X-MC-Unique: VRbcK18APUumKptAJG7fsw-1 X-Mimecast-MFC-AGG-ID: VRbcK18APUumKptAJG7fsw_1793208095 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48dfdc0f491so712787f8f.1 for ; Wed, 28 Oct 2026 10:21:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793208095; x=1793812895; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Lro1g9xiJxa67LXGW6AeolwopSOZQh+TCDnEgVoW6CU=; b=wo2BeTHxfMo459dLbI3VJv/QQJ9Rq7FZrhYd8ahir7jPm3PCWhdruzZ05dHsmwli1u gZkwVePF9x8kZ0gsgQ03s0maCJUlSEuprP5pEQSIYok0r36Mgb8S9XxoJmH4ngrjTtNx LhHow4ROcM/L4bgbsnBPXMzW5rVfiPgjuwtGVK0F/L2X9tAM/tW8PMMuY0y1icG22U1c aPltXovCzXkTgt5NsckoemcWyirT4FJ54cra5YmtV0gLMHW0/l3O0SJngM9tMbYYJ78F p91kMpJ80UQcm+XspGC++Ks8dFVwb+Ur1gvrcJpUygzK8B4w1xGIBq9QzSD2XR5IXlYg Ld+w== X-Forwarded-Encrypted: i=1; AKwUvBwcMngPHX9Y6/cnn3IWThNc0JLXcMdGEQzo14N6Bc8n/4gICeWjeonEkNYuKG0c7ZEkCX0n7VWrVIRVLQ==@sourceware.org X-Gm-Message-State: AFq9FYLmwKYVA5tOdBRkZ75SoPNO7icWlfFwmMBhU2rlzUJCNtPlWyyT ETm+kF9JEI2U2NZu5eQUIEqqM0fubIq2n/aKH9gN5X9jL2g/J1zc+FLgyeYQOsT30UN9g6dtS9T 2ZWfl8/bViOh0Gft2feouUnVvya9GJbESeQDaeVD0pkKnhtiLaxht6S7KDxNSk3E= X-Gm-Gg: AYBFou36T9QHaTejl1XVgl33py5WBEAgZysOdYB1xPWSGQC51WRysrKs4mXodVsmEqw til7hWj9WMUih2YrtBcfU3btSu/1sErnXub/DTxhONdpN7rYBzuc0uvE46z1vLQ0xKc1z8W5SJ8 YVVhmjLjxc94mpHaF2pY5N5YU64o2/huJ8w5zU1eft27DYoUsFB7gkatbBvRjxD7EoU0ZgaVYga d0pJ/dviOjtXiaJ+zKOrX9O4rhgHjEdlgty0IdsCYA8IYzfTi2RldtYrFWMDOqqJmr+h95rmur9 wj13bJcvHMNfjdbzzslYobRUu7eIVpmYcpyjeoVrCTOI98gsSSM3tbEfJYNJay0ZuhP6DVp9XIu XwCbnwSEU0KZMBvbtKjm2bqoYo55RNHvajBkNBYrm94rsFJE= X-Received: by 2002:a05:6000:178a:b0:48d:ed30:f863 with SMTP id ffacd0b85a97d-48e5d5cf411mr7174138f8f.30.1793208094983; Wed, 28 Oct 2026 10:21:34 -0700 (PDT) X-Received: by 2002:a05:6000:178a:b0:48d:ed30:f863 with SMTP id ffacd0b85a97d-48e5d5cf411mr7174094f8f.30.1793208094531; Wed, 28 Oct 2026 10:21:34 -0700 (PDT) Received: from localhost ([2a00:23c6:e11d:fb01:6748:4fce:3e30:6e23]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ebc39a8sm30563083f8f.11.2026.10.28.10.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 10:21:34 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 1/2] gdb/testsuite: fix max-completions regex in test_gdb_complete_cmd_multiple In-Reply-To: <20261026144606.1941722-1-simon.marchi@efficios.com> References: <20261026144606.1941722-1-simon.marchi@efficios.com> Date: Wed, 28 Oct 2026 17:21:33 +0000 Message-ID: <87pkwt7nc2.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: InOhZV8AjRwiZghb4FvlVKfuJhASkSY--5sDbqMWn3s_1793208095 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > When called with MAX_COMPLETIONS true and a non-empty COMPLETION_WORD, > test_gdb_complete_cmd_multiple fails to match the "List may be > truncated" line. It expects that line to start with CMD_PREFIX only > ("macro expand " in the example below), but GDB prints CMD_PREFIX > ("macro expand ") followed by COMPLETION_WORD ("BEFORE_"): > > (gdb) complete macro expand BEFORE_ > macro expand BEFORE_MACSCP1_1 > macro expand BEFORE_MACSCP1_2 > macro expand BEFORE_ *** List may be truncated, max-completions reached. *** > > Fix it by including COMPLETION_WORD in the expected line. The next > patch adds a test that depends on this. I suppose that no other test > uses this proc in this exact way currently, I don't see any regression > following this change. LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: I645197f625212dd6c654081742b3bd42fac36229 > --- > gdb/testsuite/lib/completion-support.exp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/lib/completion-support.exp b/gdb/testsuite/lib/completion-support.exp > index 112c48df6cf0..0c4b72b1c073 100644 > --- a/gdb/testsuite/lib/completion-support.exp > +++ b/gdb/testsuite/lib/completion-support.exp > @@ -246,9 +246,9 @@ proc test_gdb_complete_cmd_multiple { cmd_prefix completion_word completion_list > set expected_re [make_cmd_completion_list_re $cmd_prefix $completion_list $start_quote_char $end_quote_char] > > if {$max_completions} { > - set cmd_prefix_re [string_to_regexp $cmd_prefix] > + set input_re [string_to_regexp $cmd_prefix$completion_word] > append expected_re \ > - "$cmd_prefix_re \\*\\*\\* List may be truncated, max-completions reached\\. \\*\\*\\*.*\r\n" > + "$input_re \\*\\*\\* List may be truncated, max-completions reached\\. \\*\\*\\*.*\r\n" > } > > set cmd_re [string_to_regexp "complete $cmd_prefix$completion_word"] > > base-commit: 50b7267f00c094614ab4efb43f7aac0507a436e7 > -- > 2.56.0