From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFC: remove SIGWINCH_HANDLER and SIGWINCH_HANDLER_BODY
Date: Wed, 15 Aug 2012 15:36:00 -0000 [thread overview]
Message-ID: <87obmcuq0i.fsf@fleche.redhat.com> (raw)
As far as I can tell, nothing ever defines SIGWINCH_HANDLER or
SIGWINCH_HANDLER_BODY, so the code referring to it is dead.
Tested by rebuilding and also grepping to make sure that it isn't
defined somewhere. I also checked Insight.
Tom
* event-top.c (sigwinch_token, handle_sigwinch): Remove.
(async_init_signals): Update.
* utils.c (init_page_info): Don't use SIGWINCH_HANDLER.
(SIGWINCH_HANDLER_BODY): Remove.
diff --git a/gdb/event-top.c b/gdb/event-top.c
index 52e7852..b4a6790 100644
--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -58,9 +58,6 @@ static void handle_sigquit (int sig);
static void handle_sighup (int sig);
#endif
static void handle_sigfpe (int sig);
-#if defined(SIGWINCH) && defined(SIGWINCH_HANDLER)
-static void handle_sigwinch (int sig);
-#endif
/* Functions to be invoked by the event loop in response to
signals. */
@@ -134,9 +131,6 @@ void *sighup_token;
void *sigquit_token;
#endif
void *sigfpe_token;
-#if defined(SIGWINCH) && defined(SIGWINCH_HANDLER)
-void *sigwinch_token;
-#endif
#ifdef STOP_SIGNAL
void *sigtstp_token;
#endif
@@ -769,11 +763,6 @@ async_init_signals (void)
sigfpe_token =
create_async_signal_handler (async_float_handler, NULL);
-#if defined(SIGWINCH) && defined(SIGWINCH_HANDLER)
- signal (SIGWINCH, handle_sigwinch);
- sigwinch_token =
- create_async_signal_handler (SIGWINCH_HANDLER, NULL);
-#endif
#ifdef STOP_SIGNAL
sigtstp_token =
create_async_signal_handler (async_stop_sig, NULL);
@@ -950,17 +939,6 @@ async_float_handler (gdb_client_data arg)
divide by zero causes this, so "float" is a misnomer. */
error (_("Erroneous arithmetic operation."));
}
-
-/* Tell the event loop what to do if SIGWINCH is received.
- See event-signal.c. */
-#if defined(SIGWINCH) && defined(SIGWINCH_HANDLER)
-static void
-handle_sigwinch (int sig)
-{
- mark_async_signal_handler_wrapper (sigwinch_token);
- signal (sig, handle_sigwinch);
-}
-#endif
\f
/* Called by do_setshow_command. */
diff --git a/gdb/utils.c b/gdb/utils.c
index 607d7bc..b9e76ab 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -1714,11 +1714,6 @@ init_page_info (void)
lines_per_page = UINT_MAX;
}
- /* FIXME: Get rid of this junk. */
-#if defined(SIGWINCH) && defined(SIGWINCH_HANDLER)
- SIGWINCH_HANDLER (SIGWINCH);
-#endif
-
/* If the output is not a terminal, don't paginate it. */
if (!ui_file_isatty (gdb_stdout))
lines_per_page = UINT_MAX;
@@ -2743,11 +2738,6 @@ When set, debugging messages will be marked with seconds and microseconds."),
&setdebuglist, &showdebuglist);
}
-/* Machine specific function to handle SIGWINCH signal. */
-
-#ifdef SIGWINCH_HANDLER_BODY
-SIGWINCH_HANDLER_BODY
-#endif
/* Print routines to handle variable size regs, etc. */
/* Temporary storage using circular buffer. */
#define NUMCELLS 16
next reply other threads:[~2012-08-15 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 15:36 Tom Tromey [this message]
2012-08-15 15:44 ` Mark Kettenis
2012-08-22 14:21 ` Tom Tromey
2012-08-22 17:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obmcuq0i.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox