From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8943 invoked by alias); 23 Oct 2012 17:19:46 -0000 Received: (qmail 8823 invoked by uid 22791); 23 Oct 2012 17:19:45 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Oct 2012 17:19:40 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9NHJcuS005505 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 23 Oct 2012 13:19:38 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9NHJbUw016448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 23 Oct 2012 13:19:38 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Document replacement for frame_register_read (deprecated). References: <1350941919-9862-1-git-send-email-brobecker@adacore.com> Date: Tue, 23 Oct 2012 17:19:00 -0000 In-Reply-To: <1350941919-9862-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Mon, 22 Oct 2012 17:38:39 -0400") Message-ID: <87objtf6mu.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00421.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> This is inspired by a discussion from a long time ago: Joel> http://www.sourceware.org/ml/gdb-patches/2011-03/msg01095.html Joel> If you agree with the patch, we will also have to update the ARI Joel> script to mention get_frame_register_value as the alternative. Joel> And we might also want to rename the function as well. I don't think Joel> we can rely on the ARI alone to avoid new uses of this function. Joel> And once new uses are in, it's much harder to make sure we undo them. Joel> Thoughts? The patch seems reasonable to me. Renaming seems like a decent idea, since there is a use in jit.c, which was added long after this was deprecated. I count 22 mentions (including the declaration) of frame_register_read in the tree right now. Getting rid of all of them doesn't seem so difficult, aside from the testing. This would be clearly better... At least one of the current uses seems suspicious since it ignores the result. I assume I'm missing some context though. Tom