From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96613-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30807 invoked by alias); 5 Dec 2012 18:19:02 -0000
Received: (qmail 30795 invoked by uid 22791); 5 Dec 2012 18:19:01 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Dec 2012 18:18:56 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB5IIqHv011594	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 5 Dec 2012 13:18:52 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qB5IIpgn014747	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 5 Dec 2012 13:18:52 -0500
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA] Avoid memory leaks in set_language function.
References: <1043.9041689553$1354727529@news.gmane.org>
Date: Wed, 05 Dec 2012 18:19:00 -0000
In-Reply-To: <1043.9041689553$1354727529@news.gmane.org> (Pierre Muller's	message of "Wed, 5 Dec 2012 18:11:13 +0100")
Message-ID: <87obi8s6pg.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00086.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre> This also revealed a few memory leaks
Pierre> related to repeated add_language function calls.

Wow, add_language is gross.  I had no idea.

Pierre> +         if (iter->doc && iter->flags & DOC_ALLOCATED)

I think parens around the second clause here.
Actually I tend to prefer the wordier

    (iter->flags & DOC_ALLOCATED) != 0

Pierre>  #define MALLOCED_REPLACEMENT      0x4
Pierre> -
Pierre> +#define DOC_ALLOCATED             0x8
Pierre>  struct cmd_list_element

Please preserve the blank line after the block of #defines.

Ok with those changes.

Tom