From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14876 invoked by alias); 21 Feb 2013 21:15:17 -0000 Received: (qmail 14867 invoked by uid 22791); 21 Feb 2013 21:15:16 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Feb 2013 21:15:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1LLF80q028099 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 21 Feb 2013 16:15:08 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1LLF681024553 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 21 Feb 2013 16:15:07 -0500 From: Tom Tromey To: Joel Brobecker Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [COMMIT PATCH 2/2] Move savestring to common/common-utils.c, make gdbserver use it. References: <20130214171404.2223.83713.stgit@brno.lan> <20130214171411.2223.32326.stgit@brno.lan> <87r4kiixbe.fsf@fleche.redhat.com> <511D2805.9050606@redhat.com> <87mwv6ix72.fsf@fleche.redhat.com> <511D2980.10703@redhat.com> <20130214185413.GJ17107@adacore.com> <877gmaiqg5.fsf@fleche.redhat.com> <20130214210451.GA4550@adacore.com> Date: Thu, 21 Feb 2013 21:15:00 -0000 In-Reply-To: <20130214210451.GA4550@adacore.com> (Joel Brobecker's message of "Thu, 14 Feb 2013 13:04:51 -0800") Message-ID: <87obfd9xnp.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00576.txt.bz2 Joel> Lynx178 might also be an issue. Agreed on all other counts. Joel> I was hoping that gnulib would be our saviour, but maybe it does not Joel> implement everything we need (yet?). Tom> It has xstrndup, though it seems a bit weird to pull in 2 different Tom> definitions of that function. Also, gnulib updates seem tricky right Tom> now due to the libiconv situation. Joel> Yeah, I was definitely thinking more long term... If the libiconv Joel> situation is the only thing preventing us from doing an update, Joel> I'd go ahead, because the only known platform where this is known Joel> to potentially cause trouble is Lynx178, which I am going to guess Joel> is a fairly little used system. And AFAICT, working around the issue Joel> should be easily done by adding -DE...=... in CFLAGS when configuring Joel> the debugger. Ok, in that case, after the branch I will resurrect my gnulib patch series. I'll update it and repost it when I do that. Tom