From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1502 invoked by alias); 22 Feb 2013 20:09:50 -0000 Received: (qmail 1491 invoked by uid 22791); 22 Feb 2013 20:09:49 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Feb 2013 20:09:43 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1MK9gmN020679 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Feb 2013 15:09:42 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1MK9f1Y019226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 22 Feb 2013 15:09:41 -0500 From: Tom Tromey To: Alan Modra Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] MIPS: Compressed PLT/stubs support References: <87wqu19y1x.fsf@fleche.redhat.com> <20130222005833.GJ3080@bubble.grove.modra.org> <20130222060640.GL3080@bubble.grove.modra.org> Date: Fri, 22 Feb 2013 20:09:00 -0000 In-Reply-To: <20130222060640.GL3080@bubble.grove.modra.org> (Alan Modra's message of "Fri, 22 Feb 2013 16:36:40 +1030") Message-ID: <87obfc6rga.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00602.txt.bz2 >>>>> "Alan" == Alan Modra writes: Alan> Hmm, perhaps a cleaner change would be implement make_msymbol_special Alan> for ppc64 and move the udata.p special case out of elf_symtab_read? Alan> Like so. Alan> * elfread.c (elf_symtab_read): Do not use udata.p here to find Alan> symbol size. Alan> * ppc64-tdep.c (ppc64_elf_make_msymbol_special): New function. Alan> * ppc64-tdep.h (ppc64_elf_make_msymbol_special): Declare. Alan> * ppc-linux-tdep.c (ppc_linux_init_abi): Set up to use the above. Alan> * ppcfbsd-tdep.c (ppcfbsd_init_abi): Likewise. I like this much better, thanks. This is ok. Tom