From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13435 invoked by alias); 14 May 2013 20:14:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13396 invoked by uid 89); 14 May 2013 20:14:12 -0000 X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 14 May 2013 20:14:11 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4EKEAQL000614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 May 2013 16:14:10 -0400 Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4EKE89R013423 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 14 May 2013 16:14:09 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/5] range stepping: gdbserver (x86 GNU/Linux) References: <20130514191026.13213.39574.stgit@brno.lan> <20130514191054.13213.58686.stgit@brno.lan> Date: Tue, 14 May 2013 20:14:00 -0000 In-Reply-To: <20130514191054.13213.58686.stgit@brno.lan> (Pedro Alves's message of "Tue, 14 May 2013 20:10:54 +0100") Message-ID: <87obcd48vj.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00498.txt.bz2 Pedro> + /* Note that all addresses are always "out the step range" when Pedro> + there's no range to begin with. */ I think "out of the step range". Pedro> + else if (p[0] == 'r') Pedro> + { Pedro> + char *p1; Pedro> + Pedro> + p = p + 1; Pedro> + p1 = strchr (p, ','); Pedro> + decode_address (&resume_info[i].step_range_start, p, p1 - p); Pedro> + Pedro> + p = p1 + 1; Pedro> + p1 = strchr (p, ':'); Pedro> + decode_address (&resume_info[i].step_range_end, p, p1 - p); Pedro> + Pedro> + p = p1; Pedro> + } I don't know much about gdbserver, but reading this made me wonder if it needs to do any kind of error-checking on its input. Like - what if the wrong format is sent, or if the range end is before the range start? Tom