From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4200 invoked by alias); 18 Jun 2013 15:41:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4190 invoked by uid 89); 18 Jun 2013 15:41:59 -0000 X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 18 Jun 2013 15:41:59 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5IFfui6011715 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Jun 2013 11:41:56 -0400 Received: from barimba (ovpn-113-102.phx2.redhat.com [10.3.113.102]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5IFfs22032195 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 18 Jun 2013 11:41:55 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org, Tristan Gingold Subject: Re: [patch/Darwin] Fix cleanup leak in machoread.c:macho_symfile_read References: <20130604133005.GE12363@adacore.com> <1370942792-734-1-git-send-email-brobecker@adacore.com> Date: Tue, 18 Jun 2013 15:42:00 -0000 In-Reply-To: <1370942792-734-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Tue, 11 Jun 2013 11:26:32 +0200") Message-ID: <87obb38lz1.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-06/txt/msg00428.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> This patch prevents this by using one single cleanup queue for Joel> the entire function, rather than having additional separate Joel> cleanup queues (Eg: for the handling of the minimal symbols), Joel> thus preventing the premature free'ing of the minimal_symbols Joel> array. Joel> Secondly, this patch takes this opportunity for avoiding the use Joel> of the oso_vector global, thus making it simpler to track its Joel> lifetime. Thanks for doing this, Joel. Tom