From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21637 invoked by alias); 27 Jun 2013 20:03:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21621 invoked by uid 89); 27 Jun 2013 20:03:43 -0000 X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 27 Jun 2013 20:03:43 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5RK3fbk018632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Jun 2013 16:03:42 -0400 Received: from barimba (ovpn-113-102.phx2.redhat.com [10.3.113.102]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5RK3ea8026903 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 27 Jun 2013 16:03:41 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 01/16] use the libiberty crc code References: <1371835506-15691-1-git-send-email-tromey@redhat.com> <1371835506-15691-2-git-send-email-tromey@redhat.com> <51C87652.60105@redhat.com> Date: Thu, 27 Jun 2013 20:12:00 -0000 In-Reply-To: <51C87652.60105@redhat.com> (Pedro Alves's message of "Mon, 24 Jun 2013 17:39:46 +0100") Message-ID: <87obarmicj.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-06/txt/msg00857.txt.bz2 Pedro> (gdbserver also has it's own copy in server.c (and for that one Pedro> the return type does matter), but we don't use Pedro> libiberty-the-kitchen-sink there... Oh well.) If we used libiberty in gdbserver, we could replace this code. We'd just have to hoist the inferior-memory-reading bit outside of the crc function. This wouldn't be so bad; it might even be an improvement. I don't plan to mess with this though. Tom