From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20707 invoked by alias); 11 Sep 2013 16:55:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20695 invoked by uid 89); 11 Sep 2013 16:55:44 -0000 Received: from e06smtp11.uk.ibm.com (HELO e06smtp11.uk.ibm.com) (195.75.94.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 11 Sep 2013 16:55:44 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp11.uk.ibm.com Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 11 Sep 2013 17:48:28 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 11 Sep 2013 17:48:27 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id CC024219005A for ; Wed, 11 Sep 2013 17:55:37 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8BGtPW647251652 for ; Wed, 11 Sep 2013 16:55:25 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r8BGtbsB004868 for ; Wed, 11 Sep 2013 12:55:37 -0400 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-143.boeblingen.de.ibm.com [9.152.212.143]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r8BGtaYQ004863; Wed, 11 Sep 2013 12:55:37 -0400 From: Andreas Arnez To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset References: <877genmltz.fsf@br87z6lw.de.ibm.com> <87sixbfkb6.fsf@br87z6lw.de.ibm.com> <83sixbiaqe.fsf@gnu.org> Date: Wed, 11 Sep 2013 16:55:00 -0000 In-Reply-To: <83sixbiaqe.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 11 Sep 2013 19:28:25 +0300") Message-ID: <87ob7zfgc7.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13091116-5024-0000-0000-0000072CFC58 X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00358.txt.bz2 Eli Zaretskii writes: >> From: Andreas Arnez >> Date: Wed, 11 Sep 2013 17:29:49 +0200 >> >> --- gdb.orig/gdb/NEWS >> +++ gdb/gdb/NEWS >> @@ -111,6 +111,10 @@ show range-stepping >> * GDB now understands the element 'tvar' in the XML traceframe info. >> It has the id of the collected trace state variables. >> >> +* On S/390 targets that provide the transactional-execution feature, >> + the program interruption transaction diagnostic block (TDB) is now >> + represented as a number of additional "registers" in GDB. > > This part is OK, but the manual should cover this in more detail; I > see no reference to "TDB" in your patch for the manual. So the reader > of this NEWS entry will be unable to find any details about this new > feature. > >> --- gdb.orig/gdb/doc/gdb.texinfo >> +++ gdb/gdb/doc/gdb.texinfo > > This part is also OK, except for the above comment. Good point. Do you think the following small addition would be appropriate and sufficient? --- a/gdb/gdb/doc/gdb.texinfo +++ b/gdb/gdb/doc/gdb.texinfo @@ -42683,7 +42683,9 @@ The @samp{org.gnu.gdb.s390.tdb} feature is optional. It should contain the 64-bit registers @samp{tdb0}, @samp{tac}, @samp{tct}, -@samp{atia}, and @samp{tr0} through @samp{tr15}. +@samp{atia}, and @samp{tr0} through @samp{tr15}. These ``registers'' +represent the appropriate fields in the program interruption +transaction diagnostic block (TDB). @node TIC6x Features @subsection TMS320C6x Features Diff finished. Wed Sep 11 16:49:47 2013