From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-106178-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9902 invoked by alias); 9 Oct 2013 17:08:55 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9891 invoked by uid 89); 9 Oct 2013 17:08:54 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2013 17:08:54 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r99H8ptI028904	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 9 Oct 2013 13:08:52 -0400
Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r99H8l9d021237	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 9 Oct 2013 13:08:49 -0400
From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, ktietz@redhat.com,        gdb-patches@sourceware.org
Subject: Re: [patch] Minor O_CLOEXEC optimization, "regression" fix
References: <20131008183214.GB27355@host2.jankratochvil.net>	<87li23fsym.fsf@fleche.redhat.com>	<20131009131016.GA1603@host2.jankratochvil.net>	<83hacqqsx7.fsf@gnu.org>
Date: Wed, 09 Oct 2013 17:08:00 -0000
In-Reply-To: <83hacqqsx7.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 09 Oct	2013 20:02:12 +0300")
Message-ID: <87ob6ybcdc.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-10/txt/msg00291.txt.bz2

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

Eli> Please don't do that.  On latest versions of Windows, the runtime
Eli> library functions tend to invoke the "invalid parameter handler" in
Eli> these cases, which more often than not will crash the program.

The status quo ante was to do the call but not check for EINVAL.
So the bug, if there is one, is already there.
Can you check?

Tom