From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3579 invoked by alias); 15 Oct 2013 15:55:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3564 invoked by uid 89); 15 Oct 2013 15:55:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 15 Oct 2013 15:55:36 +0000 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r9FFtXjb025944 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 15 Oct 2013 15:55:34 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9FFtWWe025346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 15 Oct 2013 15:55:32 GMT Received: from abhmt110.oracle.com (abhmt110.oracle.com [141.146.116.62]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9FFtW6V015520 for ; Tue, 15 Oct 2013 15:55:32 GMT Received: from termi.oracle.com (/10.175.21.46) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 15 Oct 2013 08:55:31 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: gdb-patches@sourceware.org Subject: [PATCH] Fix passing double float complex arguments in sparc64 Date: Tue, 15 Oct 2013 15:55:00 -0000 Message-ID: <87ob6qo7bs.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00458.txt.bz2 Hi. Double float complex objects are not 16-byte aligned in either gcc or solaris studio. This patch makes gdb to not align double float complex arguments in the dummy frame when calling a function. This makes all the tests in gdb.base/varargs.exp to pass in sparc64-*-linux-gnu. 2013-10-15 Jose E. Marchesi * sparc64-tdep.c (sparc64_store_arguments): Do not align complex double float arguments to 16-byte. Index: sparc64-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/sparc64-tdep.c,v retrieving revision 1.62 diff -u -r1.62 sparc64-tdep.c --- sparc64-tdep.c 1 Jan 2013 06:32:51 -0000 1.62 +++ sparc64-tdep.c 15 Oct 2013 15:46:25 -0000 @@ -831,7 +831,7 @@ quad-aligned, and thus a hole might be introduced into the parameter array to force alignment." Skip an element if necessary. */ - if (num_elements % 2) + if ((num_elements % 2) && sparc64_16_byte_align_p (type)) num_elements++; } else @@ -913,7 +913,7 @@ /* Floating arguments. */ if (len == 16) { - if (element % 2) + if ((element % 2) && sparc64_16_byte_align_p (type)) element++; if (element < 16) regnum = SPARC64_Q0_REGNUM + element / 2; @@ -961,7 +961,7 @@ } else if (regnum >= SPARC64_Q0_REGNUM && regnum <= SPARC64_Q8_REGNUM) { - gdb_assert (element < 5); + gdb_assert (element < 6); regnum = SPARC_O0_REGNUM + element; regcache_cooked_write (regcache, regnum, valbuf); regcache_cooked_write (regcache, regnum + 1, valbuf + 8);