From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27261 invoked by alias); 4 Nov 2013 16:27:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27231 invoked by uid 89); 4 Nov 2013 16:27:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Nov 2013 16:26:28 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA4GQIwF002088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 4 Nov 2013 11:26:18 -0500 Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rA4GQGAX013760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 4 Nov 2013 11:26:17 -0500 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 4/4] Test on solib load and unload References: <1383291300-13917-1-git-send-email-yao@codesourcery.com> <1383291300-13917-5-git-send-email-yao@codesourcery.com> <87eh6zyi6j.fsf@fleche.redhat.com> <52746817.7060902@codesourcery.com> Date: Mon, 04 Nov 2013 17:37:00 -0000 In-Reply-To: <52746817.7060902@codesourcery.com> (Yao Qi's message of "Sat, 2 Nov 2013 10:48:55 +0800") Message-ID: <87ob60uo9j.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00062.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> Using a list makes caller code cleaner if multiple lines are written. Yao> I am fine to use one big string here. You can always join a list in the caller: set list [however-you-make-it] gdb_produce_source filename [join $list \n] Yao> * lib/gdb.exp (gdb_produce_source): New procedure. Yao> * gdb.perf/solib.c: New. Yao> * gdb.perf/solib.exp: New. Yao> * gdb.perf/solib.py: New. Looks good to me, thanks. Tom