From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24811 invoked by alias); 21 May 2014 18:01:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24802 invoked by uid 89); 21 May 2014 18:01:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 May 2014 18:01:38 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LI1YTB014152 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 May 2014 14:01:34 -0400 Received: from barimba (ovpn-113-182.phx2.redhat.com [10.3.113.182]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4LI1XDK023431 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 21 May 2014 14:01:33 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 03/12] Iterate over 'struct varobj_item' instead of PyObject References: <1392367471-13527-1-git-send-email-yao@codesourcery.com> <1392367471-13527-4-git-send-email-yao@codesourcery.com> Date: Wed, 21 May 2014 18:01:00 -0000 In-Reply-To: <1392367471-13527-4-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Fri, 14 Feb 2014 16:44:22 +0800") Message-ID: <87oayrj9j6.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-05/txt/msg00498.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2014-02-14 Pedro Alves Yao> Yao Qi Yao> * python/py-varobj.c (py_varobj_iter_next): Move some code Yao> from varobj.c. Yao> * varobj-iter.h (struct varobj_item): Moved from varobj.c. Yao> * varobj.c: Move "varobj-iter.h" inclusion earlier. Yao> (struct varobj_item): Moved to varobj-iter.h". Yao> (varobj_clear_saved_item): New function. Yao> (update_dynamic_varobj_children): Move python-related code to Yao> py-varobj.c. Yao> (free_variable): Call varobj_clear_saved_item and Yao> varobj_iter_delete. This looks reasonable but I have a question first: Yao> @@ -802,14 +802,8 @@ update_dynamic_varobj_children (struct varobj *var, Yao> int to) Yao> { Yao> #if HAVE_PYTHON Yao> - struct cleanup *back_to; Yao> int i; Yao> - if (!gdb_python_initialized) Yao> - return 0; Where is this check done now? I couldn't find the location. IIRC this check was added in response to some bug report; I think it only arises if Python can't be properly initialized somehow. If it was dropped I think it may need to be reinstated somewhere. Tom