From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11943 invoked by alias); 22 May 2014 16:13:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11893 invoked by uid 89); 22 May 2014 16:13:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=unavailable version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 May 2014 16:13:01 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WnVc0-0007nZ-Hx from Thomas_Schwinge@mentor.com ; Thu, 22 May 2014 09:12:56 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 22 May 2014 09:12:56 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Thu, 22 May 2014 17:12:54 +0100 From: Thomas Schwinge To: Gary Benson CC: Andrew Burgess , Ian Lance Taylor , gcc-patches , Jason Merrill , Subject: Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special. In-Reply-To: <20140522160208.GC25201@blade.nx> References: <1399646123-9960-1-git-send-email-aburgess@broadcom.com> <536E7A72.1040203@broadcom.com> <20140514090125.GA4974@blade.nx> <537337AF.3020806@broadcom.com> <20140514142016.GA32660@blade.nx> <87a9aavxdr.fsf@kepler.schwinge.homeip.net> <20140522160208.GC25201@blade.nx> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Thu, 22 May 2014 16:13:00 -0000 Message-ID: <87oayp7px9.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2014-05/txt/msg00558.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1439 Hi Gary! On Thu, 22 May 2014 17:02:08 +0100, Gary Benson wrote: > Thomas Schwinge wrote: > > In GCC, I'm consistenly seeing the following new failure: > >=20 > > ./test-demangle < ../../../source/libiberty/testsuite/demangle-expe= cted > > FAIL at line 4350, options --format=3Dauto --no-params: > > in: _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > out: (null) > > exp:=20 > > ./test-demangle: 895 tests, 1 failures > > make[2]: *** [check-cplus-dem] Error 1 > >=20 > > The patch was committed incompletely; I added the missing last line in > > r210803: > [snip] > > @@ -4347,3 +4347,4 @@ void post >(std::function<= void ()>&&)::{lambda()#1}*& std > > --format=3Dauto --no-params > > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z > > +_QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z >=20 > I thought that extra line was a mistake; I thought each test was > precisely three lines: >=20 > # options > # input to be demangled > # expected output >=20 > What is the extra line here? I too had to look it up -- see the explanation at the beginning of the file: # --no-params There are two lines of expected output; the fi= rst # is with DMGL_PARAMS, the second is without it. Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTfiIDAAoJENuKOtuXzphJ1UgH/09tqNrK18RngX2HnQIfTjeR vuzj39tIAZ8xlUPtV0Tv6LXdRUQcVAc5f/CZAChB2RcTWNA+bp7DY144ZQPfsIR1 u8P4aPdP8fvFbMD8zkWqNx3G1eqorrAPF37X5Sr50Rd1w34elAbSZTEc1U56vBsH Q+Xwnf32oh4v8xbwCCyIiogf3cmXz3xw+2qFFyuUPYG79ZUSkRsoOlu0X/TWrdqn i3Nto6g+hvvBX9Dsz8GeySe9Bnwq7cOKzCu8YxFkju0Ph37ZEuylT6HELO1V03xT mzZET2klJIv+OggwFFGv3iF57COedcyPdvsPzU+O1fCMUszsKo7phe8M8czpsvM= =1+qP -----END PGP SIGNATURE----- --=-=-=--