From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14282 invoked by alias); 4 Jun 2014 20:15:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14269 invoked by uid 89); 4 Jun 2014 20:15:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jun 2014 20:15:39 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s54KFYcP006543 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Jun 2014 16:15:35 -0400 Received: from barimba ([10.3.113.4]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s54KFXKC014715 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 4 Jun 2014 16:15:34 -0400 From: Tom Tromey To: Yao Qi Cc: Joel Brobecker , Subject: Re: [ping] [PATCH] Different outputs affected by locale References: <1401192650-29688-1-git-send-email-yao@codesourcery.com> <538EAEE5.2080708@codesourcery.com> <20140604124708.GR4289@adacore.com> <538F1CC3.9090605@codesourcery.com> Date: Wed, 04 Jun 2014 20:15:00 -0000 In-Reply-To: <538F1CC3.9090605@codesourcery.com> (Yao Qi's message of "Wed, 4 Jun 2014 21:18:59 +0800") Message-ID: <87oay8a0t6.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-06/txt/msg00214.txt.bz2 >>>>> "Yao" =3D=3D Yao Qi writes: Yao> The character printed by GDB in this case is out the control of GDB, Yao> IMO. IOW, we can't tell what character printed is correct and what is Yao> incorrect. Or we can relax the pattern to match either \242 or '=C2= =A2' Yao> (cent sign) in the test. WDYT? I think that would be preferable. It is more conservative for the reason Joel pointed out; and should we encounter a system that emits something else, it is easy to update the test at that time. I am not really a great standards lawyer but my first reaction is that mingw's C locale is not conforming. At least from: http://pubs.opengroup.org/onlinepubs/009604499/basedefs/xbd_chap07.html .. it seems to me that \242 is not defined as a 'print' character in the LC_CTYPE section. Though I'd like to reiterate that I don't actually trust my own reading of that text. Tom