Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Skip dlopen-libpthread.exp in cross testing
Date: Sun, 28 Sep 2014 03:51:00 -0000	[thread overview]
Message-ID: <87oau0wgmx.fsf@codesourcery.com> (raw)
In-Reply-To: <542436DE.4030005@redhat.com> (Pedro Alves's message of "Thu, 25	Sep 2014 16:38:06 +0100")

Pedro Alves <palves@redhat.com> writes:

> I think we should put an "error" call in build_executable_own_libs
> too, so that whoever adds the next test that uses this doesn't
> end up forgetting the same thing.

OK, how about this below?

Subject: [PATCH] Error in build_executable_own_libs for non-native target

gdb/testsuite:

2014-09-28  Yao Qi  <yao@codesourcery.com>

	* lib/prelink-support.exp (build_executable_own_libs): Error if
	the target isn't native.

diff --git a/gdb/testsuite/lib/prelink-support.exp b/gdb/testsuite/lib/prelink-support.exp
index a0fb12b..113a078 100644
--- a/gdb/testsuite/lib/prelink-support.exp
+++ b/gdb/testsuite/lib/prelink-support.exp
@@ -118,6 +118,10 @@ proc file_copy {src dest} {
 proc build_executable_own_libs {testname executable sources options {interp ""} {dir ""}} {
     global subdir
 
+    if { ![isnative] } {
+	error "This proc can be only used for native target."
+    }
+
     if {[build_executable $testname $executable $sources $options] == -1} {
 	return ""
     }
-- 
Yao (齐尧)


  reply	other threads:[~2014-09-28  3:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25  7:57 Yao Qi
2014-09-25 15:38 ` Pedro Alves
2014-09-28  3:51   ` Yao Qi [this message]
2014-09-29 15:28     ` Pedro Alves
2014-09-30  4:05       ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oau0wgmx.fsf@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox