From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13664 invoked by alias); 13 Apr 2015 06:47:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13653 invoked by uid 89); 13 Apr 2015 06:47:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Apr 2015 06:47:04 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3D6kwbk006266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 13 Apr 2015 02:47:00 -0400 Received: from localhost (unused-10-15-17-126.yyz.redhat.com [10.15.17.126]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3D6kvRT007099 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO); Mon, 13 Apr 2015 02:46:57 -0400 From: Sergio Durigan Junior To: Doug Evans Cc: Yao Qi , gdb-patches Subject: Re: [RFC] Unset tcl variable addr to avoid clashing References: <1428666671-12926-1-git-send-email-qiyaoltc@gmail.com> <87r3rqppgq.fsf@redhat.com> X-URL: http://blog.sergiodj.net Date: Mon, 13 Apr 2015 06:47:00 -0000 In-Reply-To: (Doug Evans's message of "Sun, 12 Apr 2015 10:22:22 -0700") Message-ID: <87oamsmsnz.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00451.txt.bz2 On Sunday, April 12 2015, Doug Evans wrote: >> FWIW, there is not strong reason to keep the variable name as "addr" in >> the testcase. So, an easier solution would be to rename the variable to >> something else, like "coredump_var_addr" (I think this name is unique >> enough). The patch below does that. >> >> WDYT? >> >> -- >> Sergio >> GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 >> Please send encrypted e-mail if possible >> http://sergiodj.net/ >> >> gdb/testsuite/ChangeLog: >> 2015-04-11 Sergio Durigan Junior >> >> * gdb.base/coredump-filter.exp: Rename variable "addr" to >> "coredump_var_addr" to avoid naming conflict with other >> testcases. > > Ok by me with one nit. > There's an issue here that still needs to be documented so it becomes > part of the collective lore. > Can this include a note about the need to give global array variables > unique names to either testsuite/README or > https://sourceware.org/gdb/wiki/Internals%20GDB-Testsuite-Coding-Standards Thanks, pushed: 8cd8f2f8ac49276437b7da37f275706ea1c1c925 And updated the internals manual: -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/