Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Doug Evans <dje@google.com>, Yao Qi <qiyaoltc@gmail.com>,
	       gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] Unset tcl variable addr to avoid clashing
Date: Sun, 26 Apr 2015 19:44:00 -0000	[thread overview]
Message-ID: <87oama7jyo.fsf@redhat.com> (raw)
In-Reply-To: <87r3rmjzi5.fsf@redhat.com> (Sergio Durigan Junior's message of	"Tue, 14 Apr 2015 15:12:02 -0400")

On Tuesday, April 14 2015, I wrote:

> What do you think of the following patch (obvious, but I decided to send
> anyway)?  This is just to make things 100% correct, and I don't think
> it's worth reverting the renaming.

FWIW, I've checked the patch in.

> I will also expand/fix the update I did in the wiki page.

And I've also updated the wiki.

> Thanks,
>
> -- 
> Sergio
> GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
> Please send encrypted e-mail if possible
> http://sergiodj.net/
>
> gdb/testsuite/ChangeLog:
> 2015-04-14  Sergio Durigan Junior  <sergiodj@redhat.com>
>
> 	* gdb.base/coredump-filter.exp: Clear variable "coredump_var_addr"
> 	before using it.
>
> diff --git a/gdb/testsuite/gdb.base/coredump-filter.exp b/gdb/testsuite/gdb.base/coredump-filter.exp
> index f872de0..72f756a 100644
> --- a/gdb/testsuite/gdb.base/coredump-filter.exp
> +++ b/gdb/testsuite/gdb.base/coredump-filter.exp
> @@ -170,6 +170,7 @@ gdb_test_multiple "print/x &main" "getting main's address" {
>  
>  # Obtain the address of each variable that will be checked on each
>  # case.
> +set coredump_var_addr ""
>  foreach item $all_anon_corefiles {
>      foreach name [list [lindex $item 3] [lindex $item 4]] {
>  	set test "print/x $name"

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


      reply	other threads:[~2015-04-26 19:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10 11:51 Yao Qi
2015-04-10 16:53 ` Doug Evans
2015-04-10 17:55   ` Keith Seitz
2015-04-10 18:08     ` Doug Evans
2015-04-11 17:03 ` Sergio Durigan Junior
2015-04-12 17:22   ` Doug Evans
2015-04-13  6:47     ` Sergio Durigan Junior
2015-04-13  8:26     ` Pedro Alves
2015-04-14 19:12       ` Sergio Durigan Junior
2015-04-26 19:44         ` Sergio Durigan Junior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oama7jyo.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox