Re: [PATCH] Make sure GDB uses a valid shell when starting the inferior and to perform the "shell" command

Eli Zaretskii
2015-07-25T07:10:52Z

> Date: Fri, 24 Jul 2015 16:09:40 -0400
> From: Simon Marchi <simon.marchi@ericsson.com>
> CC: <gdb-patches@sourceware.org>
>
> On 15-07-24 03:53 PM, Eli Zaretskii wrote:
> > I don't think there are so many shells out there that we run a real
> > risk of forgetting them.
>
> Even though you can try to list all known shells, they won't necessarily
> be in the same location. For example, the servers I work on at work have
> an old version of everything, so I use my own version of bash. SHELL won't
> be /bin/bash but /home/<user>/local/bin/bash. gdb wouldn't recognize it as
> a valid shell.

I didn't say that, but meant to suggest testing only the basename of
the shell.

> > And even if we do, there's plenty of time
> > till the next release to hear from those who might be negatively
> > impacted.
>
> I don't think that's true. The number of users who go build and use gdb
> from the master branch is probably negligible. If this affects some users,
> it will most likely be when it gets released in distros (months or years
> after the actual release, depending on the distro).

Fine, have it your way, and let's see if that flies. I thought the
fact that we've got 2 additional candidates in less than 1 day is
evidence that more will follow, but I guess we will see.