From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65738 invoked by alias); 25 Jul 2015 16:30:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65729 invoked by uid 89); 25 Jul 2015 16:29:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 25 Jul 2015 16:29:58 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 898BC2C9DC9; Sat, 25 Jul 2015 16:29:57 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6PGTuLX013651 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 25 Jul 2015 12:29:57 -0400 From: Sergio Durigan Junior To: Eli Zaretskii Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Make sure GDB uses a valid shell when starting the inferior and to perform the "shell" command References: <1437761993-18758-1-git-send-email-sergiodj@redhat.com> <55B2850D.6030306@ericsson.com> <87k2tp5q3g.fsf@redhat.com> <838ua52wmp.fsf@gnu.org> <87fv4d5p8l.fsf@redhat.com> <837fpp2uz5.fsf@gnu.org> <55B29B84.5000707@ericsson.com> <8361583e6v.fsf@gnu.org> X-URL: http://blog.sergiodj.net Date: Sat, 25 Jul 2015 16:30:00 -0000 In-Reply-To: <8361583e6v.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Jul 2015 10:10:32 +0300") Message-ID: <87oaj042uz.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00748.txt.bz2 On Saturday, July 25 2015, Eli Zaretskii wrote: >> > And even if we do, there's plenty of time >> > till the next release to hear from those who might be negatively >> > impacted. >> >> I don't think that's true. The number of users who go build and use gdb >> from the master branch is probably negligible. If this affects some users, >> it will most likely be when it gets released in distros (months or years >> after the actual release, depending on the distro). > > Fine, have it your way, and let's see if that flies. I thought the > fact that we've got 2 additional candidates in less than 1 day is > evidence that more will follow, but I guess we will see. Maybe I should have been more clear about what I want to achieve with this patch. My goal was not to match every possible invalid shell out there, nor to make sure that the specified shell is a known and valid shell. My goal was to make sure that the shell exists, is an executable, and is not something that is commonly used to disable logins (/sbin/nologin or /bin/false are the obvious candidates here). The 2 additional candidates that have been mentioned were actually just 1: I did not remember to include /bin/false in the list before, but /usr/sbin/nologin is nologin (and I could even just check for the basename as you proposed in another message, eliminating the need to include checks for {,/usr}). I don't think we will see the list of non-shells expanding much more. One can always say "Hey, but /bin/ls is a not a shell!", and we will say "Right, and it is not commonly used as shell anyway". Finally, I don't want to forbid the user to specify her own shell to run the inferior, and to name her shell as she wants. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/