From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128939 invoked by alias); 22 Sep 2016 20:37:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128797 invoked by uid 89); 22 Sep 2016 20:37:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:4.86_1, H*F:U*tom X-HELO: gproxy4-pub.mail.unifiedlayer.com Received: from gproxy4-pub.mail.unifiedlayer.com (HELO gproxy4-pub.mail.unifiedlayer.com) (69.89.23.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 22 Sep 2016 20:36:56 +0000 Received: (qmail 1424 invoked by uid 0); 22 Sep 2016 20:36:54 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy4.mail.unifiedlayer.com with SMTP; 22 Sep 2016 20:36:54 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id mkcp1t00q2f2jeq01kcsV6; Thu, 22 Sep 2016 14:36:52 -0600 X-Authority-Analysis: v=2.1 cv=F4vEKMRN c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=GW1xBdLrtEIA:10 a=20KFwNOVAAAA:8 a=fxm5poL_DzLLq0XSxCUA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 174-16-151-161.hlrn.qwest.net ([174.16.151.161]:58232 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bnAji-0000yv-Tn; Thu, 22 Sep 2016 14:36:51 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 2/5] Use std::string in cp-namespace.c References: <1474566656-15389-1-git-send-email-tom@tromey.com> <1474566656-15389-3-git-send-email-tom@tromey.com> <2e60c3c8-800c-36c7-c3c1-a53583ac91fd@redhat.com> Date: Thu, 22 Sep 2016 20:56:00 -0000 In-Reply-To: <2e60c3c8-800c-36c7-c3c1-a53583ac91fd@redhat.com> (Pedro Alves's message of "Thu, 22 Sep 2016 20:03:12 +0100") Message-ID: <87oa3fzn6m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bnAji-0000yv-Tn X-Source-Sender: 174-16-151-161.hlrn.qwest.net (bapiya) [174.16.151.161]:58232 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-09/txt/msg00299.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 09/22/2016 06:50 PM, Tom Tromey wrote: >> - name_copy[prefix_len] = '\0'; >> + name_copy.erase (prefix_len, name_copy.size ()); Pedro> Passing name_copy.size () here looks odd, since that parameter is Pedro> how many bytes to erase. Just don't pass a second parameter, Pedro> which defaults to std::string::npos? For some reason I was under the impression that the 1-arg form just removed a single character, but I see that's incorrect. Thanks. Tom