Re: [PATCH v4] gdb: ADI support

Yao Qi
2017-07-25T16:44:47Z

jose.marchesi@oracle.com (Jose E. Marchesi) writes:

> General question: what's wrong with using a simple linked list of
> structs if that is the developer's preference, and/or it follows the
> current style of the surrounding code? (Not saying it is in this case,
> that's up to Weimin to say.)

It makes the code a little bit unnecessarily complicated, IOW, std::list
or std::forward_list can make it simpler. My preference is to use
standard c++ data structure rather than re-inventing it again.

>
> As far as I can see the usage of STL is not mandated by the GDB coding
> standards (as documented in the wiki) and developers may want to avoid
> them in many circumstances.

It is out of the scope of coding standard. GDB is a C++ project,
when we organize something as a list, it is quite natural to use
standard c++ data structure.

--
Yao (齐尧)