From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96106 invoked by alias); 8 Dec 2017 16:28:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96073 invoked by uid 89); 8 Dec 2017 16:28:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:2473 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Dec 2017 16:28:49 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AA376A0497 for ; Fri, 8 Dec 2017 16:28:48 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F5B464446; Fri, 8 Dec 2017 16:28:48 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [RFA] Adjust gdb.arch/i386-sse-stack-align.exp print statement References: <1499959929-29497-9-git-send-email-palves@redhat.com> <20171207233015.18656-1-sergiodj@redhat.com> <71f1cec5-d299-6b08-4189-84f35e18fc4c@redhat.com> Date: Fri, 08 Dec 2017 16:28:00 -0000 In-Reply-To: <71f1cec5-d299-6b08-4189-84f35e18fc4c@redhat.com> (Pedro Alves's message of "Fri, 8 Dec 2017 10:47:47 +0000") Message-ID: <87o9n918w0.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00190.txt.bz2 On Friday, December 08 2017, Pedro Alves wrote: > On 12/07/2017 11:30 PM, Sergio Durigan Junior wrote: >> >> commit 46a4882b3c7d9ec981568b8b13a3c9c39c8f8e61 >> Author: Pedro Alves >> Date: Mon Sep 4 20:21:15 2017 +0100 >> >> Stop assuming no-debug-info variables have type int >> >> We now have to explicitly tell GDB the type of the non-debug-info >> variable we want to print (by casting). This commit adjusts the >> "print" statement on gdb.arch/i386-sse-stack-align.exp to do the >> proper cast, fixing a failure that started to happen after the >> mentioned commit. >> >> gdb/testsuite/ChangeLog: >> 2017-12-07 Sergio Durigan Junior >> >> * gdb.arch/i386-sse-stack-align.exp: Cast "print" variable to >> "int". > > This is OK, except... > >> --- >> gdb/testsuite/ChangeLog | 5 +++++ >> gdb/testsuite/gdb.arch/i386-sse-stack-align.exp | 2 +- >> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog >> index 53f114aa15..81d23d1bb1 100644 >> --- a/gdb/testsuite/ChangeLog >> +++ b/gdb/testsuite/ChangeLog >> @@ -1,3 +1,8 @@ >> +2017-12-07 Sergio Durigan Junior >> + >> + * gdb.arch/i386-sse-stack-align.exp: Cast "print" variable to >> + "int". >> + >> 2017-12-07 Keith Seitz >> >> * gdb.cp/nested-types.cc: New file. >> diff --git a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp >> index 47fb9f42d2..946f217ce1 100644 >> --- a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp >> +++ b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp >> @@ -43,7 +43,7 @@ if ![runto_main] then { >> >> set args "" >> foreach i {0 1 2 3 4} { >> - set test "print g$i ($args)" >> + set test "print (int) g$i ($args)" > > ... this is printing/calling a function, not a variable: > > (gdb) print g0 () > 'g0' has unknown return type; cast the call to its declared return type > > So the git log and ChangeLog are inaccurate and should > reference 7022349d5c86 ("Stop assuming no-debug-info functions > return int") instead. > > OK with that fixed. Thanks for the catch, I adjusted the ChangeLog entry and the commit message accordingly. Pushed: 1cd9a73b4280cb133b305ee31a0e87f114bd1be8 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/