From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42065 invoked by alias); 14 Feb 2018 01:28:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41606 invoked by uid 89); 14 Feb 2018 01:28:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1926 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Feb 2018 01:28:29 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8F84E4023141; Wed, 14 Feb 2018 01:28:27 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 641B02141200; Wed, 14 Feb 2018 01:28:27 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: GDB Patches , Jan Kratochvil Subject: Re: [PATCH] Check for ncursesw first when searching for "tgetent" References: <20180131210430.23787-1-sergiodj@redhat.com> <87d118hfs7.fsf@redhat.com> Date: Wed, 14 Feb 2018 01:28:00 -0000 In-Reply-To: <87d118hfs7.fsf@redhat.com> (Sergio Durigan Junior's message of "Tue, 13 Feb 2018 14:04:56 -0500") Message-ID: <87o9ksfjgk.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00198.txt.bz2 On Tuesday, February 13 2018, I wrote: > On Monday, February 12 2018, Simon Marchi wrote: > >> On 2018-01-31 04:04 PM, Sergio Durigan Junior wrote: >>> Commit 5007d765ae09c10c7f3b18bb16841b9d2d59e181 ("Allow linking GDB >>> with ncursesw") modified our configure.ac and included the check for >>> "ncursesw" when searching for "waddstr". However, there's one more >>> place where we should check for "ncursesw" first: >>> >>> AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses]) >>> >>> This patch changes the order of the libraries to be searched when >>> looking for "tgetent", and puts "ncursesw" before "curses ...". >>> >>> This is another patch we carry on Fedora GDB. >> >> I think it makes sense, but can you expand on why this is needed? > > The rationale for this patch was: > > https://bugzilla.redhat.com/show_bug.cgi?id=1270534 > > This is a bug that happened on Fedora GDB when linking against ncurses, > but not ncursesw. The bug has been fixed upstream by commit > 5007d765ae09c10c7f3b18bb16841b9d2d59e181, but the AC_SEARCH_LIBS line > for tgetent has not been modified, so, for the sake of completeness, I > think it makes sense to leave configure.ac in a consistent state (i.e., > requiring ncursesw over ncurses whenever applicable). > > I guess that's the gist of it. There's not much that can be said, the > patch is really simple and its intention is to make things more uniform. > > I can include the link to the Red Hat bug in the commit message, if you > want. After talking to Pedro in private, I was convinced that this is not the right explanation for the patch, either. Therefore, I will write a better commit message and submit a v2, hopefully addressing your concerns. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/