From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39103 invoked by alias); 15 Jun 2018 16:43:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39091 invoked by uid 89); 15 Jun 2018 16:43:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:509 X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.54.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Jun 2018 16:43:19 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 19E07400C5D3A for ; Fri, 15 Jun 2018 11:43:18 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Tro8f1EorbXuJTroUfEp72; Fri, 15 Jun 2018 11:43:17 -0500 X-Authority-Reason: nr=8 Received: from [12.176.89.6] (port=56540 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fTro7-001QeB-TC; Fri, 15 Jun 2018 11:42:40 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] default_type_align: Use type_length_units References: <1528928623-27479-1-git-send-email-simon.marchi@ericsson.com> <877en1e23t.fsf@tromey.com> <87y3fhcflw.fsf@tromey.com> Date: Fri, 15 Jun 2018 16:43:00 -0000 In-Reply-To: (Simon Marchi's message of "Thu, 14 Jun 2018 18:27:50 -0400") Message-ID: <87o9gcgfwh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fTro7-001QeB-TC X-Source-Sender: (pokyo) [12.176.89.6]:56540 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-06/txt/msg00405.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Here's what I pushed. However, I parsed the "and update the comment" of your reply Simon> after pushing. Which comment did you want me to update? Sorry that was unclear -- I meant if you decided not to use type_length_units, then update the comment in gdbtypes.h to follow. But, since you did do the type_length_units change, that's not relevant. Thanks for fixing this btw. Tom