From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70802 invoked by alias); 8 Jul 2018 16:52:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70790 invoked by uid 89); 8 Jul 2018 16:52:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=letter X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:52:17 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id C6CCA9924E8 for ; Sun, 8 Jul 2018 11:52:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cCv1fOS8IRPojcCv1fyGAC; Sun, 08 Jul 2018 11:52:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=w64R4qsJ66Re5zvHZn5oKc0YkhJwHrwKhXbM3b1ARWw=; b=ez+hXKK7zC8Bs67IvVs9v7jZTs klB8rcoXuCzsAZ+dyDRnnbnCk+P6ppaHf2tEYkm2eGduiUUI8VsGyZBJcVwNPSwwALVT68JKXzw10 DUqFYGL47xwOfNH3+RdlMzXmc; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:43068 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fcCv1-001Vij-8c; Sun, 08 Jul 2018 11:52:15 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 04/42] Move last_source file to buildsym_compunit References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-5-tom@tromey.com> <87a7r1662j.fsf@tromey.com> Date: Sun, 08 Jul 2018 16:52:00 -0000 In-Reply-To: (Simon Marchi's message of "Sun, 8 Jul 2018 12:37:38 -0400") Message-ID: <87o9fh4qma.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00197.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-07-08 12:33 PM, Tom Tromey wrote: >> All the data members are private by the end of the series, but I didn't >> generally try to do that at each step along the way. This is one of >> those compromises I mentioned in the cover letter -- where a bigger >> reordering of the series might have yielded a prettier series, but >> didn't seem worth the effort. Simon> Ok, no problem then. You can ignore other similar comments I've Simon> already sent. I already sent one other reply but you can likewise ignore that :) This series is a bit unwieldy. And I should probably have mentioned earlier (before Keith went to the effort of applying it...) that it is in my github as submit/buildsym-fixups, in case you wanted to check it out or something. Tom