From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59979 invoked by alias); 16 Aug 2018 17:42:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59954 invoked by uid 89); 16 Aug 2018 17:42:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=Hx-languages-length:959 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Aug 2018 17:41:59 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7GHXfQJ044208 for ; Thu, 16 Aug 2018 13:41:57 -0400 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0b-001b2d01.pphosted.com with ESMTP id 2kwc19n022-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 16 Aug 2018 13:41:57 -0400 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 16 Aug 2018 13:41:56 -0400 Received: from b01cxnp22033.gho.pok.ibm.com (9.57.198.23) by e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 16 Aug 2018 13:41:55 -0400 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7GHfsJB28115102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 16 Aug 2018 17:41:54 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BA215AC060; Thu, 16 Aug 2018 13:42:13 -0400 (EDT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 71911AC05E; Thu, 16 Aug 2018 13:42:13 -0400 (EDT) Received: from pedro.localdomain (unknown [9.18.235.43]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 16 Aug 2018 13:42:13 -0400 (EDT) Received: by pedro.localdomain (Postfix, from userid 1000) id E47773C03E5; Thu, 16 Aug 2018 14:41:51 -0300 (-03) From: Pedro Franco de Carvalho To: Pedro Alves , gdb-patches@sourceware.org Cc: uweigand@de.ibm.com, edjunior@gmail.com Subject: Re: [PATCH v4 00/12] GDB support for more powerpc registers on linux In-Reply-To: <0f08d344-7096-c9fc-6eed-0215d3f63001@redhat.com> References: <20180815000608.26840-1-pedromfc@linux.ibm.com> <87wosqntwa.fsf@linux.vnet.ibm.com> <0f08d344-7096-c9fc-6eed-0215d3f63001@redhat.com> Date: Thu, 16 Aug 2018 17:42:00 -0000 MIME-Version: 1.0 Content-Type: text/plain x-cbid: 18081617-0064-0000-0000-0000033CCC6F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009556; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01074439; UDB=6.00553695; IPR=6.00854397; MB=3.00022759; MTD=3.00000008; XFM=3.00000015; UTC=2018-08-16 17:41:56 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18081617-0065-0000-0000-00003A530F52 Message-Id: <87o9e2xl7k.fsf@linux.vnet.ibm.com> X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00405.txt.bz2 Pedro Alves writes: > I was reading through the series as you sent this. I sent a couple > comments to patches #12 and #14. The remarks in #12 is something that can > always be addressed with this series already merged. Re. the comments for #14, > it would be nice to go over the series and add missing intro comments to > functions, etc. Otherwise, it all LGTM. I only really skimmed > it for mechanics, since as you say Ulrich already reviewed it, and I'm > far from a Power expert anyway. Thanks a lot going through these! I will add comments before commiting. >> I don't know if a NEWS item counts as obvious, but if not, I can submit >> it in a separate patch. > > It's usually reviewed like other patches. gdb/NEWS falls under > Eli's documentation maintainership. Ok, I'll submit it separately so that Eli can have a look at it. -- Pedro Franco de Carvalho