From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85940 invoked by alias); 19 Sep 2018 12:57:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84991 invoked by uid 89); 19 Sep 2018 12:57:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Sep 2018 12:57:15 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 3F20F16C45F for ; Wed, 19 Sep 2018 07:57:14 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2c22gillgbXuJ2c2Qg0XTu; Wed, 19 Sep 2018 07:57:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=S6FOlbJDo1JwoSXMipFD4+wF5suFnzeoBDFzrSNwHlQ=; b=VwoSUDjiKAG33/U5HrRa7HlXrA UwdKt/6MsNqRVyLEQYmCCrMSiJmbqMZSrLl0VrYliqcvXAT0RpU9JcZ3miqfWpzwD5tS2paC578K3 Dr2wZl03+4nrxpzI139dHBLUa; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:54198 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g2c22-002DSQ-2H; Wed, 19 Sep 2018 07:56:38 -0500 From: Tom Tromey To: Sandra Loosemore Cc: "gdb-patches\@sourceware.org" Subject: Re: [patch, testsuite] skip tab-completion tests if no readline References: Date: Wed, 19 Sep 2018 12:57:00 -0000 In-Reply-To: (Sandra Loosemore's message of "Tue, 18 Sep 2018 22:23:49 -0600") Message-ID: <87o9ctr6gq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00678.txt.bz2 >>>>> "Sandra" == Sandra Loosemore writes: Sandra> I found a bunch of borked tab-completion tests when running tests on a Sandra> remote Windows host, where the input stream is not a tty and has no Sandra> readline support. I've copied the test for readline support verbatim Sandra> from the older gdb.base/completion.exp testcase into these newer Sandra> testcases. OK to commit? Actually, I had a couple thoughts just as I hit send... Sandra> # This file is part of the gdb testsuite. Sandra> +# Tests below are about tab-completion, which doesn't work if readline Sandra> +# library isn't used. Check it first. Sandra> + Sandra> +if { ![readline_is_used] } { Sandra> + return -1 Sandra> +} Perhaps the early returns should call "untested". I'm on the fence about this, sometimes it is done, sometimes not. I don't know if it matters to anybody -- I never really look at these lines. https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#A.22untested.22_calls Second, this particular check runs early. I wonder if readline_is_used actually works at this spot, because I would imagine gdb isn't running yet. What does "runtest cpls-ops.exp" do? Tom