From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100833 invoked by alias); 5 Oct 2018 14:18:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100819 invoked by uid 89); 5 Oct 2018 14:18:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.209) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Oct 2018 14:18:49 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 2451367B0 for ; Fri, 5 Oct 2018 09:18:40 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 8QwCgar0179N38QwCgi6Bj; Fri, 05 Oct 2018 09:18:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZdiPSV3JTRVFwQ74Y+AkIJ0Z14PT+A/nDOyhpP47+3U=; b=cscRoivjfenHq/OkJD6glNIOtw 0b7zUb179oaCgRH8iGn9+4ejVj7Qb2EysQmOrJwYW3+XAwhO6pr43R9hFkcxWhV31EDRCn1Ch80MC KYb4iI/Wlw2K6iEXJqBoxZfCb; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:54428 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g8QwB-000YT2-Qj; Fri, 05 Oct 2018 09:18:39 -0500 From: Tom Tromey To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix buffer overrun found by Coverity References: <1538747591-32283-1-git-send-email-gbenson@redhat.com> Date: Fri, 05 Oct 2018 14:18:00 -0000 In-Reply-To: <1538747591-32283-1-git-send-email-gbenson@redhat.com> (Gary Benson's message of "Fri, 5 Oct 2018 14:53:11 +0100") Message-ID: <87o9c8h3y9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00131.txt.bz2 >>>>> "Gary" == Gary Benson writes: Gary> I would have committed this as obvious, but the testsuite doesn't Gary> exercise this piece of code; I can't realistically say I've regression Gary> tested this change, so I'd like another pair of eyes on it to be sure. What about the fission-dwp.exp board maybe? Or one of the other boards. Gary> - memset (ids, 255, (DW_SECT_MAX + 1) * sizeof (int32_t)); Gary> - memset (ids_seen, 255, (DW_SECT_MAX + 1) * sizeof (int32_t)); Gary> + memset (ids, 255, sizeof_ids); Gary> + memset (ids_seen, 255, sizeof (ids_seen)); Later the code does this: if (id < DW_SECT_MIN || id > DW_SECT_MAX) { error (_("Dwarf Error: bad DWP hash table, bad section id %d" [...] ids_seen[id] = i; ids[i] = id; So I think it would be good to ensure that MAX_NR_V2_DWO_SECTIONS is >= DW_SECT_MAX + 1. At least if I'm understanding this properly. Tom