From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122390 invoked by alias); 12 Mar 2019 16:48:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116932 invoked by uid 89); 12 Mar 2019 16:48:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=escaped, 040, sk:print_s, list'ing X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Mar 2019 16:48:11 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 830776CE91 for ; Tue, 12 Mar 2019 11:48:09 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 3kZVhas8YYTGM3kZVhpIkX; Tue, 12 Mar 2019 11:48:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=47kEW6QF1jmIEkHBMmQAGN9oxYEmIIRgUwRd3nSKQdE=; b=kNPqTIRj9eAsgEsWhfSzCJrGT0 C6lfbdc1fqVgIOJpwQl6B7TbCMiQn/dMCj+1AK5LS96NanVee5BsyKHYfFpjaE2QNIuFPBORlW52l 8pn/aintOxRi+V0xZPpMjRT3O; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:34682 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h3kZV-003WRE-7h; Tue, 12 Mar 2019 11:48:09 -0500 From: Tom Tromey To: Cc: Hannes Domani Subject: Re: [RFC 8.3 0/3] Some style fixes References: <20190308210433.32683-1-tromey@adacore.com> <1828778750.3318305.1552141698307@mail.yahoo.com> Date: Tue, 12 Mar 2019 16:48:00 -0000 In-Reply-To: <1828778750.3318305.1552141698307@mail.yahoo.com> (Hannes Domani via gdb-patches's message of "Sat, 9 Mar 2019 14:28:18 +0000 (UTC)") Message-ID: <87o96g3upj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00241.txt.bz2 >>>>> "Hannes" == Hannes Domani via gdb-patches writes: Hannes> 1) Outside of TUI, escaped characters (< 040 and 0177) aren't handled correctly any more when Hannes> list'ing some source code, resulting in an endless loop. Hannes> See print_source_lines_base(), I just added "++iter" in the last 2 if() blocks, that fixed it for me. Hannes> 2) In TUI, scrolling right with the arrow keys, the first keypress doesn't do anything. Hannes> (that's just a very minor nuisance) Hannes> 3) Again in TUI, scrolling right handles TABS and escaped characters as single characters, Hannes> which just looks weird. Thanks, I will take a look at these. I suspect #2 is the nonl problem. Could you try the patch I sent in another branch of this thread? Tom