From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65405 invoked by alias); 18 Mar 2019 16:43:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65392 invoked by uid 89); 18 Mar 2019 16:43:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:651 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Mar 2019 16:43:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 89179561B9; Mon, 18 Mar 2019 12:43:31 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id m38BPqF0fXyR; Mon, 18 Mar 2019 12:43:31 -0400 (EDT) Received: from murgatroyd (174-29-37-56.hlrn.qwest.net [174.29.37.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 0F212561B7; Mon, 18 Mar 2019 12:43:31 -0400 (EDT) From: Tom Tromey To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , "tromey\@adacore.com" , nd Subject: Re: [PATCH] Fix Arm build error References: <20190318162759.31241-1-alan.hayward@arm.com> Date: Mon, 18 Mar 2019 16:43:00 -0000 In-Reply-To: <20190318162759.31241-1-alan.hayward@arm.com> (Alan Hayward's message of "Mon, 18 Mar 2019 16:28:06 +0000") Message-ID: <87o9682kwd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00386.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> The following commit broke the build for Arm: Alan> d3a70e03cf51c8fb6bc183eaff7559edffec2045 Alan> Change iterate_over_lwps to take a gdb::function_view Alan> Correct the changes made to arm_linux_insert_hw_breakpoint1 and make Alan> similar changes to arm_linux_remove_hw_breakpoint1. Alan> 2019-03-18 Alan Hayward Alan> * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix Alan> variable names. Alan> (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view. Thanks. Please check it in if you haven't already. Tom