From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122856 invoked by alias); 26 Mar 2019 20:52:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122843 invoked by uid 89); 26 Mar 2019 20:52:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.1 spammy=keypress, ls, HX-Languages-Length:1187, H*f:sk:2019030 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Mar 2019 20:52:34 +0000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2QKngoH043642 for ; Tue, 26 Mar 2019 16:52:32 -0400 Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rfrea00a9-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 26 Mar 2019 16:52:32 -0400 Received: from localhost by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 26 Mar 2019 20:52:31 -0000 Received: from b01cxnp22036.gho.pok.ibm.com (9.57.198.26) by e15.ny.us.ibm.com (146.89.104.202) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 26 Mar 2019 20:52:17 -0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x2QKqGRL13041846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Mar 2019 20:52:16 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1771D112061; Tue, 26 Mar 2019 20:52:16 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DA882112063; Tue, 26 Mar 2019 20:52:15 +0000 (GMT) Received: from pedro.localdomain (unknown [9.80.229.54]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 26 Mar 2019 20:52:15 +0000 (GMT) Received: by pedro.localdomain (Postfix, from userid 1000) id 2AC773C046E; Tue, 26 Mar 2019 17:52:13 -0300 (-03) From: Pedro Franco de Carvalho To: Tom Tromey , gdb-patches@sourceware.org Cc: Hannes Domani Subject: Re: [RFC 8.3 0/3] Some style fixes In-Reply-To: <87o96g3upj.fsf@tromey.com> References: <20190308210433.32683-1-tromey@adacore.com> <1828778750.3318305.1552141698307@mail.yahoo.com> <87o96g3upj.fsf@tromey.com> Date: Tue, 26 Mar 2019 20:52:00 -0000 MIME-Version: 1.0 Content-Type: text/plain x-cbid: 19032620-0068-0000-0000-000003AB69E9 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010819; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000282; SDB=6.01180086; UDB=6.00617544; IPR=6.00960801; MB=3.00026168; MTD=3.00000008; XFM=3.00000015; UTC=2019-03-26 20:52:31 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19032620-0069-0000-0000-000047F1D9F3 Message-Id: <87o95x2waq.fsf@linux.vnet.ibm.com> X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00611.txt.bz2 Hello, It seems that issue 1) that Hannes reported is still present, and affects both master and the release branch. Control characters like form feed are being printed infinitely in the CLI when listing a source file (for form feed lots of "^L"s are being printed). Thanks! -- Pedro Franco de Carvalho Tom Tromey writes: >>>>>> "Hannes" == Hannes Domani via gdb-patches writes: > > Hannes> 1) Outside of TUI, escaped characters (< 040 and 0177) aren't handled correctly any more when > Hannes> list'ing some source code, resulting in an endless loop. > Hannes> See print_source_lines_base(), I just added "++iter" in the last 2 if() blocks, that fixed it for me. > > Hannes> 2) In TUI, scrolling right with the arrow keys, the first keypress doesn't do anything. > Hannes> (that's just a very minor nuisance) > > Hannes> 3) Again in TUI, scrolling right handles TABS and escaped characters as single characters, > Hannes> which just looks weird. > > Thanks, I will take a look at these. > > I suspect #2 is the nonl problem. Could you try the patch I sent in > another branch of this thread? > > Tom