From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109901 invoked by alias); 16 Apr 2019 19:49:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109892 invoked by uid 89); 16 Apr 2019 19:49:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Apr 2019 19:49:02 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 790FB67480C for ; Tue, 16 Apr 2019 14:49:01 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id GU4jh6ZGL90onGU4jhHiWK; Tue, 16 Apr 2019 14:49:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8nHl7Np2bkg/9KyLmQEha9GmKEapprJtJcjJr0Zuedc=; b=DcbHE/vjZAOtZZiBSINdEt5FlS xApDqzmG64JIdurrBvlwjCmQDlk4gTCoDN+Pz1eYQBt+au5Lfjy6CZdrGAgpqawF7JumQq63RhkTO iHaOLZWQn9Q4LMr00MYkpGaC8; Received: from 75-166-39-124.hlrn.qwest.net ([75.166.39.124]:45790 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hGU4j-004Gil-6e; Tue, 16 Apr 2019 14:49:01 -0500 From: Tom Tromey To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH 4/4] testsuite: Add option to capture gdbserver debug References: <20190416101729.16176-1-alan.hayward@arm.com> <20190416101729.16176-5-alan.hayward@arm.com> Date: Tue, 16 Apr 2019 19:49:00 -0000 In-Reply-To: <20190416101729.16176-5-alan.hayward@arm.com> (Alan Hayward's message of "Tue, 16 Apr 2019 10:17:43 +0000") Message-ID: <87o955spcj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00278.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> Add board option which enables gdbserver debug and sends it to the Alan> file gdbserver.log, located in the output directory for the current Alan> test. Document this. Alan> Add debug versions of the native gdbserver board files. Alan> Disable tspeed.exp when debugging to prevent the log file filling Alan> many gigabytes then timing out. Thanks. Alan> +gdbserver,debug Alan> + Alan> + When set gdbserver debug is outputed to the file gdbserver.log in the test I think it should say "is sent" rather than "is outputed". Alan> diff --git a/gdb/testsuite/boards/native-extended-gdbserver-debug.exp b/gdb/testsuite/boards/native-extended-gdbserver-debug.exp I wonder if a new board is needed for this? Could it be done some other way, like a command-line setting? TBH I'm not sure what the typical approach is for something like this. Alan> if {![info exists gdbserver_reconnect_p] || !$gdbserver_reconnect_p} { Alan> # GDB client could accidentally connect to a stale server. Alan> - # append gdbserver_command " --debug --once" Alan> append gdbserver_command " --once" Was this intentional? One random thought I had about this series is that it would be nice to have a way to get "set remotelogfile" output in the test directory. That way a failing test could be re-run with gdbreplay without much trouble. Tom