Re: [PATCH 1/6] Introduce scoped_pipe.h

Sergio Durigan Junior
2020-02-28T16:08:54Z

On Friday, February 28 2020, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> gdb/ChangeLog:
> Sergio> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>
>
> Sergio> * unittests/scoped_pipe-selftests.c: New file.
>
> Sergio> gdbsupport/ChangeLog:
> Sergio> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>
>
> Sergio> * scoped_pipe.h: New file.
>
> I think new general-purpose code should go in gdbsupport.

Yep. scoped_pipe.h is there.

> Unfortunately right now we don't have a good way to put the unit tests
> there. This is something we ought to do eventually though.

Right, that's something I noticed as well.

> Sergio> +#ifndef COMMON_SCOPED_PIPE_H
>
> I think we've been using GDBSUPPORT rather than COMMON now.

Ah, OK. I found other places using COMMON, but I'll change it here.

> Sergio> + explicit scoped_pipe ()
>
> I think explicit is only needed for 1-arg constructors.

OK, I'll remove the keyword.

I'll make the changes locally.

Thanks,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible